Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(354)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: net/http/http_network_transaction.cc

Issue 507033: When talking to a SOCKS v5 proxy, default to sending addresses as raw domains... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Address wtc's comments Created 11 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/http/http_network_transaction_unittest.cc » ('j') | net/socket_stream/socket_stream.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/http/http_network_transaction.cc
===================================================================
--- net/http/http_network_transaction.cc (revision 34785)
+++ net/http/http_network_transaction.cc (working copy)
@@ -652,7 +652,7 @@
req_info.set_referrer(request_->referrer);
if (proxy_info_.proxy_server().scheme() == ProxyServer::SCHEME_SOCKS5)
- s = new SOCKS5ClientSocket(s, req_info, session_->host_resolver());
+ s = new SOCKS5ClientSocket(s, req_info, NULL /*use proxy-side resolving*/);
wtc 2009/12/17 23:23:04 Nit: unless you're trying to fit in 80 chars, it l
else
s = new SOCKSClientSocket(s, req_info, session_->host_resolver());
connection_.set_socket(s);
« no previous file with comments | « no previous file | net/http/http_network_transaction_unittest.cc » ('j') | net/socket_stream/socket_stream.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698