Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 507013002: Fix dialog screen position. (Closed)

Created:
6 years, 3 months ago by Jamie
Modified:
6 years, 3 months ago
Reviewers:
garykac
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix dialog screen position. https://codereview.chromium.org/478033004/ broke the dialog screen, causing it to cover the title-bar in apps v2. This fixes it be adding an explicit <div> representing the window client area (the logical <body> for apps v2). Committed: https://crrev.com/6c9ccd1a53b92f8aef4f4bdd2bc8b665849cc02e Cr-Commit-Position: refs/heads/master@{#292465}

Patch Set 1 #

Patch Set 2 : Fix indent. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -52 lines) Patch
M remoting/webapp/html/template_main.html View 1 1 chunk +56 lines, -52 lines 0 comments Download
M remoting/webapp/window_frame.css View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
Jamie
jamiewalch@chromium.org changed reviewers: + garykac@chromium.org
6 years, 3 months ago (2014-08-26 19:48:20 UTC) #1
Jamie
PTAL. Patchset 1 contains the actual change. Patchset 2 is just an indent change (the ...
6 years, 3 months ago (2014-08-26 19:48:20 UTC) #2
garykac
lgtm
6 years, 3 months ago (2014-08-28 17:01:09 UTC) #3
Jamie
The CQ bit was checked by jamiewalch@chromium.org
6 years, 3 months ago (2014-08-28 18:46:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamiewalch@chromium.org/507013002/20001
6 years, 3 months ago (2014-08-28 18:48:24 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_gn_rel on tryserver.chromium.linux ...
6 years, 3 months ago (2014-08-28 19:43:02 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 3 months ago (2014-08-28 20:04:09 UTC) #7
commit-bot: I haz the power
Failed to commit the patch.
6 years, 3 months ago (2014-08-28 20:04:10 UTC) #8
Jamie
The CQ bit was checked by jamiewalch@chromium.org
6 years, 3 months ago (2014-08-28 21:25:53 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamiewalch@chromium.org/507013002/20001
6 years, 3 months ago (2014-08-28 21:27:36 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 8e7c7891b1c4d84c7aef29c167914ea76714280d
6 years, 3 months ago (2014-08-28 21:38:40 UTC) #11
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:02:21 UTC) #12
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/6c9ccd1a53b92f8aef4f4bdd2bc8b665849cc02e
Cr-Commit-Position: refs/heads/master@{#292465}

Powered by Google App Engine
This is Rietveld 408576698