Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Issue 507003002: Set the shelf icon title explicitly for settings and task manager (Closed)

Created:
6 years, 3 months ago by stevenjb
Modified:
6 years, 3 months ago
Reviewers:
sky
CC:
chromium-reviews, sadrul, tfarina, yoshiki+watch_chromium.org, rginda+watch_chromium.org, kalyank, ben+ash_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Set the shelf icon title explicitly for settings and task manager This allows us to set the icon title (used for hovertext) independently of the window title (which is empty for Settings windows). BUG=406954 Committed: https://crrev.com/7de8523b61785562a74ba09e7f8916e1e7c607ee Cr-Commit-Position: refs/heads/master@{#292029}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -10 lines) Patch
M ash/shelf/shelf_util.h View 2 chunks +5 lines, -3 lines 0 comments Download
M ash/shelf/shelf_util.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/ash/launcher/browser_status_monitor.cc View 2 chunks +4 lines, -1 line 0 comments Download
M chrome/browser/ui/ash/launcher/multi_profile_browser_status_monitor.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/task_manager_view.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
stevenjb
stevenjb@chromium.org changed reviewers: + sky@chromium.org
6 years, 3 months ago (2014-08-26 19:28:33 UTC) #1
stevenjb
6 years, 3 months ago (2014-08-26 19:28:33 UTC) #2
sky
LGTM
6 years, 3 months ago (2014-08-26 20:37:17 UTC) #3
stevenjb
The CQ bit was checked by stevenjb@chromium.org
6 years, 3 months ago (2014-08-26 20:40:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stevenjb@chromium.org/507003002/1
6 years, 3 months ago (2014-08-26 20:41:03 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_tests_recipe on tryserver.chromium.linux ...
6 years, 3 months ago (2014-08-26 22:22:23 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (1) as 2f88e541b15782e627074def2ca13892e1733aad
6 years, 3 months ago (2014-08-26 23:33:08 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:47:19 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7de8523b61785562a74ba09e7f8916e1e7c607ee
Cr-Commit-Position: refs/heads/master@{#292029}

Powered by Google App Engine
This is Rietveld 408576698