Properly separate host and target builds when using external natives.

Properly separate host and target builds when using external natives.

R=rmcilroy@chromium.org, vogelheim@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=23522

[baixo, 2014-08-26 18:30:23]

baixo@chromium.org changed reviewers:
+ mcilroy@chromium.org, vogelheim@chromium.org

[baixo, 2014-08-26 18:30:23]

Please take a look.

[vogelheim, 2014-08-27 09:57:23]

lgtm

Thanks for fixing this!

[baixo, 2014-08-27 13:49:19]

baixo@chromium.org changed reviewers:
+ rmcilroy@chromium.org
- mcilroy@chromium.org

[baixo, 2014-08-29 13:59:07]

Could you guys take another look, please?

Builds were not working correctly because the blobs could be generated from
multiple targets (host and target). This was fixed.

[rmcilroy, 2014-08-29 14:02:48]

On 2014/08/29 13:59:07, baixo wrote:
> Could you guys take another look, please?
> 
> Builds were not working correctly because the blobs could be generated from
> multiple targets (host and target). This was fixed.

lgtm, I'll commit if vogelheim thinks this is OK.

[vogelheim, 2014-08-29 14:10:55]

https://codereview.chromium.org/506983002/diff/20001/tools/gyp/v8.gyp
File tools/gyp/v8.gyp (right):

https://codereview.chromium.org/506983002/diff/20001/tools/gyp/v8.gyp#newcode281
tools/gyp/v8.gyp:281: '<(PRODUCT_DIR)/snapshot_blob_host.bin',
I'm a bit skeptical here: snapshot.cc and snapshot_blob.bin represent largely
the same data, but in a different format: One as constants in C, the other as a
blob file. So if we disambiguate between the host and target blob file, we would
probably also disambiguate the equivalent .cc file.

Admittedly this is more pattern matching than a specific problem this might
cause, but... well.

[rmcilroy, 2014-08-29 14:15:47]

https://codereview.chromium.org/506983002/diff/20001/tools/gyp/v8.gyp
File tools/gyp/v8.gyp (right):

https://codereview.chromium.org/506983002/diff/20001/tools/gyp/v8.gyp#newcode281
tools/gyp/v8.gyp:281: '<(PRODUCT_DIR)/snapshot_blob_host.bin',
On 2014/08/29 14:10:55, vogelheim wrote:
> I'm a bit skeptical here: snapshot.cc and snapshot_blob.bin represent largely
> the same data, but in a different format: One as constants in C, the other as
a
> blob file. So if we disambiguate between the host and target blob file, we
would
> probably also disambiguate the equivalent .cc file.
> 
> Admittedly this is more pattern matching than a specific problem this might
> cause, but... well.

I think the difference is that snapshot.cc is already disambiguated between host
/ target because it is in <(INTERMEDIATE_DIR) (which is different for host and
target), whereas <(PRODUCT_DIR) is the same for both the host / target builds
and so has to be explicitly differentiated.

[vogelheim, 2014-08-29 14:55:39]

lgtm

https://codereview.chromium.org/506983002/diff/20001/tools/gyp/v8.gyp
File tools/gyp/v8.gyp (right):

https://codereview.chromium.org/506983002/diff/20001/tools/gyp/v8.gyp#newcode281
tools/gyp/v8.gyp:281: '<(PRODUCT_DIR)/snapshot_blob_host.bin',
Ah, yes, that makes sense. Thanks for the explanation!

[rmcilroy, 2014-08-29 15:05:05]

Committed patchset #2 (id:20001) manually as 23522 (presubmit successful).