Issue 506953002: Revert of Suppress an uninitialized value in KeyboardLayoutManager::SetChildBounds.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 506953002: Revert of Suppress an uninitialized value in KeyboardLayoutManager::SetChildBounds. (Closed)

Created:
6 years, 3 months ago by Jeffrey Yasskin

Modified:
6 years, 3 months ago

Reviewers:
bshe

CC:
chromium-reviews, glider+watch_chromium.org, timurrrr+watch_chromium.org, bruening+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@lkcr

Project:
chromium

Visibility:
Public.

Revert of Suppress an uninitialized value in KeyboardLayoutManager::SetChildBounds. (patchset #1 of https://codereview.chromium.org/502183003/) Reason for revert: https://codereview.chromium.org/480723006/ fixed this. Original issue's description: > Suppress an uninitialized value in KeyboardLayoutManager::SetChildBounds. > > BUG=407467 > TBR=bshe@chromium.org > > Committed: https://chromium.googlesource.com/chromium/src/+/1598e5ab15e3c24f6d17e2214e61185d1098c915 TBR=bshe@chromium.org NOTREECHECKS=true NOTRY=true BUG=407467 Committed: https://crrev.com/c9f0746c227b722b328e2179aac21ebe0393b265 Cr-Commit-Position: refs/heads/master@{#291907}

Created: 6 years, 3 months ago

(Patch set is too large to download)

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -6 lines)			Patch
	M	tools/valgrind/memcheck/suppressions.txt	View		1 chunk	+0 lines, -6 lines	0 comments	Download

Total messages: 4 (0 generated)

Jeffrey Yasskin

Created Revert of Suppress an uninitialized value in KeyboardLayoutManager::SetChildBounds.

6 years, 3 months ago (2014-08-26 15:30:22 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jyasskin@chromium.org/506953002/1

6 years, 3 months ago (2014-08-26 15:30:37 UTC) #2

commit-bot: I haz the power

Committed patchset #1 (1) as 7170c18917e14c78d3b3c3b0262f101cb7754a2b

6 years, 3 months ago (2014-08-26 15:31:18 UTC) #3

commit-bot: I haz the power

6 years, 3 months ago (2014-09-10 02:42:57 UTC) #4

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/c9f0746c227b722b328e2179aac21ebe0393b265
Cr-Commit-Position: refs/heads/master@{#291907}