Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Unified Diff: media/formats/mp2t/es_parser_adts_unittest.cc

Issue 506943003: Support MPEG1 audio in the MPEG2-TS stream parser. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address CR comments from patch set #5. Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/filters/stream_parser_factory.cc ('k') | media/formats/mp2t/es_parser_mpeg1audio.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/formats/mp2t/es_parser_adts_unittest.cc
diff --git a/media/formats/mp2t/es_parser_adts_unittest.cc b/media/formats/mp2t/es_parser_adts_unittest.cc
index c9dd47c54b486c014dbd4281472ad24fe0c4a03f..a65635a53a6356b56f1d3b1654522988fcc12f2e 100644
--- a/media/formats/mp2t/es_parser_adts_unittest.cc
+++ b/media/formats/mp2t/es_parser_adts_unittest.cc
@@ -27,8 +27,6 @@ class EsParserAdtsTest : public EsParserTestBase,
protected:
bool Process(const std::vector<Packet>& pes_packets, bool force_timing);
- std::vector<Packet> GenerateFixedSizePesPacket(size_t pes_size);
-
private:
DISALLOW_COPY_AND_ASSIGN(EsParserAdtsTest);
};
@@ -46,23 +44,6 @@ bool EsParserAdtsTest::Process(
return ProcessPesPackets(&es_parser, pes_packets, force_timing);
}
-std::vector<EsParserTestBase::Packet>
-EsParserAdtsTest::GenerateFixedSizePesPacket(size_t pes_size) {
- DCHECK_GT(stream_.size(), 0u);
- std::vector<Packet> pes_packets;
-
- Packet cur_pes_packet;
- cur_pes_packet.offset = 0;
- cur_pes_packet.pts = kNoTimestamp();
- while (cur_pes_packet.offset < stream_.size()) {
- pes_packets.push_back(cur_pes_packet);
- cur_pes_packet.offset += pes_size;
- }
- ComputePacketSize(&pes_packets);
-
- return pes_packets;
-}
-
TEST_F(EsParserAdtsTest, NoInitialPts) {
LoadStream("bear.adts");
std::vector<Packet> pes_packets = GenerateFixedSizePesPacket(512);
« no previous file with comments | « media/filters/stream_parser_factory.cc ('k') | media/formats/mp2t/es_parser_mpeg1audio.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698