Wire up GetKeyDataEx() in Chrome

Wire up GetKeyDataEx() in Chrome

This CL wires up cryptohomed's GetKeyDataEx() as
HomedirMethods::GetKeyDataEx() in Chrome. The method will be used to
retrieve metadata such as the hashing algorithm and salt used for a
key.

BUG=367847
TEST=New homedir_methods_unittest.cc

Committed: https://crrev.com/2401bb93e76413176246a41be2a51de1e43137a0
Cr-Commit-Position: refs/heads/master@{#292602}

[bartfab (slow), 2014-08-26 15:15:27]

bartfab@chromium.org changed reviewers:
+ dkrahn@chromium.org

[bartfab (slow), 2014-08-26 15:15:27]

Hi Darren,

After the discussion in CL 488633003, I believe you are the most appropriate
reviewer for this CL as well and should be becoming an owner of
chromeos/cryptohome soon as well.

Could you please take a look?

[Darren Krahn, 2014-08-26 20:14:22]

https://codereview.chromium.org/506943002/diff/1/chromeos/cryptohome/cryptoho...
File chromeos/cryptohome/cryptohome_parameters.h (right):

https://codereview.chromium.org/506943002/diff/1/chromeos/cryptohome/cryptoho...
chromeos/cryptohome/cryptohome_parameters.h:70: struct CHROMEOS_EXPORT
RetrievedKeyData {
This seems to simply dup the classes generated by the proto. Is there a reason
why we need to do this instead of just using the proto classes directly?

https://codereview.chromium.org/506943002/diff/1/chromeos/dbus/cryptohome_cli...
File chromeos/dbus/cryptohome_client.h (right):

https://codereview.chromium.org/506943002/diff/1/chromeos/dbus/cryptohome_cli...
chromeos/dbus/cryptohome_client.h:461: // present, this does not include any
secret information and the calll should
nit: calll -> call

https://codereview.chromium.org/506943002/diff/1/chromeos/dbus/cryptohome_cli...
chromeos/dbus/cryptohome_client.h:462: // be be unauthenticated (|auth| should
be empty).
nit: be be -> not be

[bartfab (slow), 2014-08-27 11:53:15]

https://codereview.chromium.org/506943002/diff/1/chromeos/cryptohome/cryptoho...
File chromeos/cryptohome/cryptohome_parameters.h (right):

https://codereview.chromium.org/506943002/diff/1/chromeos/cryptohome/cryptoho...
chromeos/cryptohome/cryptohome_parameters.h:70: struct CHROMEOS_EXPORT
RetrievedKeyData {
On 2014/08/26 20:14:21, Darren Krahn wrote:
> This seems to simply dup the classes generated by the proto. Is there a reason
> why we need to do this instead of just using the proto classes directly?

I followed the design of the other calls abstracted by HomedirMethods. They all
translate from a protobuf to a corresponding struct. I am not sure what the
reasoning behind the original design was. It certainly does encapsulate input
validation and hides the complexity and ugliness of protobuf parsing by passing
around an easier-to-user struct instead.

https://codereview.chromium.org/506943002/diff/1/chromeos/dbus/cryptohome_cli...
File chromeos/dbus/cryptohome_client.h (right):

https://codereview.chromium.org/506943002/diff/1/chromeos/dbus/cryptohome_cli...
chromeos/dbus/cryptohome_client.h:461: // present, this does not include any
secret information and the calll should
On 2014/08/26 20:14:22, Darren Krahn wrote:
> nit: calll -> call

Done.

https://codereview.chromium.org/506943002/diff/1/chromeos/dbus/cryptohome_cli...
chromeos/dbus/cryptohome_client.h:462: // be be unauthenticated (|auth| should
be empty).
On 2014/08/26 20:14:22, Darren Krahn wrote:
> nit: be be -> not be

Done.

[Darren Krahn, 2014-08-27 16:17:00]

On 2014/08/27 11:53:15, bartfab wrote:
>
https://codereview.chromium.org/506943002/diff/1/chromeos/cryptohome/cryptoho...
> File chromeos/cryptohome/cryptohome_parameters.h (right):
> 
>
https://codereview.chromium.org/506943002/diff/1/chromeos/cryptohome/cryptoho...
> chromeos/cryptohome/cryptohome_parameters.h:70: struct CHROMEOS_EXPORT
> RetrievedKeyData {
> On 2014/08/26 20:14:21, Darren Krahn wrote:
> > This seems to simply dup the classes generated by the proto. Is there a
reason
> > why we need to do this instead of just using the proto classes directly?
> 
> I followed the design of the other calls abstracted by HomedirMethods. They
all
> translate from a protobuf to a corresponding struct. I am not sure what the
> reasoning behind the original design was. It certainly does encapsulate input
> validation and hides the complexity and ugliness of protobuf parsing by
passing
> around an easier-to-user struct instead.
> 
>
https://codereview.chromium.org/506943002/diff/1/chromeos/dbus/cryptohome_cli...
> File chromeos/dbus/cryptohome_client.h (right):
> 
>
https://codereview.chromium.org/506943002/diff/1/chromeos/dbus/cryptohome_cli...
> chromeos/dbus/cryptohome_client.h:461: // present, this does not include any
> secret information and the calll should
> On 2014/08/26 20:14:22, Darren Krahn wrote:
> > nit: calll -> call
> 
> Done.
> 
>
https://codereview.chromium.org/506943002/diff/1/chromeos/dbus/cryptohome_cli...
> chromeos/dbus/cryptohome_client.h:462: // be be unauthenticated (|auth| should
> be empty).
> On 2014/08/26 20:14:22, Darren Krahn wrote:
> > nit: be be -> not be
> 
> Done.

lgtm

[bartfab (slow), 2014-08-27 16:18:39]

The CQ bit was checked by bartfab@chromium.org

[commit-bot: I haz the power, 2014-08-27 16:19:27]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/bartfab@chromium.org/506943002/20001

[bartfab (slow), 2014-08-27 17:02:06]

The CQ bit was unchecked by bartfab@chromium.org

[bartfab (slow), 2014-08-28 11:44:21]

The CQ bit was checked by bartfab@chromium.org

[commit-bot: I haz the power, 2014-08-28 11:44:51]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/bartfab@chromium.org/506943002/20001

[commit-bot: I haz the power, 2014-08-28 12:08:52]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[commit-bot: I haz the power, 2014-08-28 12:18:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-28 12:18:03]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[bartfab (slow), 2014-08-28 16:34:09]

The CQ bit was checked by bartfab@chromium.org

[commit-bot: I haz the power, 2014-08-28 16:35:26]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/bartfab@chromium.org/506943002/40001

[commit-bot: I haz the power, 2014-08-28 17:33:45]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios_dbg_simulator on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)

[commit-bot: I haz the power, 2014-08-28 17:43:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-28 17:43:17]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[bartfab (slow), 2014-08-29 08:13:50]

Patchset #4 (id:60001) has been deleted

[bartfab (slow), 2014-08-29 08:15:54]

The CQ bit was checked by bartfab@chromium.org

[commit-bot: I haz the power, 2014-08-29 08:16:43]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/bartfab@chromium.org/506943002/80001

[commit-bot: I haz the power, 2014-08-29 09:29:40]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[bartfab (slow), 2014-08-29 09:35:38]

The CQ bit was checked by bartfab@chromium.org

[commit-bot: I haz the power, 2014-08-29 09:35:44]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/bartfab@chromium.org/506943002/100001

[commit-bot: I haz the power, 2014-08-29 10:50:37]

Committed patchset #5 (id:100001) as e9b4de10793febdacc59c650e27635be26438c41

[commit-bot: I haz the power, 2014-09-10 03:07:34]

Patchset 5 (id:??) landed as
https://crrev.com/2401bb93e76413176246a41be2a51de1e43137a0
Cr-Commit-Position: refs/heads/master@{#292602}