Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Issue 506903003: Remove implicit conversions from scoped_refptr to T* in content/browser/media/ (Closed)

Created:
6 years, 3 months ago by dcheng
Modified:
6 years, 3 months ago
Reviewers:
DaleCurtis
CC:
chromium-reviews, darin-cc_chromium.org, feature-media-reviews_chromium.org, jam, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove implicit conversions from scoped_refptr to T* in content/browser/media/ This patch was generated by running the rewrite_scoped_refptr clang tool on a Linux build. BUG=110610 Committed: https://crrev.com/7707e9723cb455714dc24b94eff1b633632f7746 Cr-Commit-Position: refs/heads/master@{#291965}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -8 lines) Patch
M content/browser/media/capture/content_video_capture_device_core.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M content/browser/media/capture/desktop_capture_device_aura.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M content/browser/media/webrtc_getusermedia_browsertest.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
dcheng
dcheng@chromium.org changed reviewers: + dalecurtis@chromium.org
6 years, 3 months ago (2014-08-26 17:14:02 UTC) #1
dcheng
Unfortunately, we can't make scoped_refptr testable until the conversion operator has been removed. While it ...
6 years, 3 months ago (2014-08-26 17:14:02 UTC) #2
DaleCurtis
lgtm
6 years, 3 months ago (2014-08-26 18:53:10 UTC) #3
dcheng
The CQ bit was checked by dcheng@chromium.org
6 years, 3 months ago (2014-08-26 18:55:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dcheng@chromium.org/506903003/1
6 years, 3 months ago (2014-08-26 18:57:10 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (1) as 97b6019c748030dd6a1bc8ccaaf137e760a54849
6 years, 3 months ago (2014-08-26 19:37:43 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:44:59 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7707e9723cb455714dc24b94eff1b633632f7746
Cr-Commit-Position: refs/heads/master@{#291965}

Powered by Google App Engine
This is Rietveld 408576698