native_client_sdk/src/tools/common.mk - Issue 506863005: [NaCl SDK] getos.py now checks against the Cr-Commit-Position.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: native_client_sdk/src/tools/common.mk

Issue 506863005: [NaCl SDK] getos.py now checks against the Cr-Commit-Position. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@sbc-nacl-sdk-fix-getos-tests

Patch Set: Use tuples for comparison. Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: native_client_sdk/src/tools/common.mk

diff --git a/native_client_sdk/src/tools/common.mk b/native_client_sdk/src/tools/common.mk

index b50195e419c3328b4a9242878277a78bde692096..a4e827ad05b00866549b00bc20f42624aa96bd5c 100644

--- a/native_client_sdk/src/tools/common.mk

+++ b/native_client_sdk/src/tools/common.mk

@@ -204,6 +204,9 @@ TC_PATH := $(abspath $(NACL_SDK_ROOT)/toolchain)

# Check for required minimum SDK version.

+# A makefile can declare NACL_SDK_VERSION_MIN of the form "<major>.<position>",

+# where <major> is the major Chromium version number, and <position> is the

+# Chromium Cr-Commit-Position number. eg. "39.295386".

ifdef NACL_SDK_VERSION_MIN

VERSION_CHECK:=$(shell $(GETOS) --check-version=$(NACL_SDK_VERSION_MIN) 2>&1)

« no previous file with comments | « no previous file | native_client_sdk/src/tools/getos.py » ('j') | native_client_sdk/src/tools/getos.py » ('J')