Issue 506863003: Componentize google_util_unittest

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 506863003: Componentize google_util_unittest (Closed)

Created:
6 years, 3 months ago by blundell

Modified:
6 years, 3 months ago

Reviewers:
Peter Kasting

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

Componentize google_util_unittest The file can be moved into the component as-is. BUG=373245 Committed: https://crrev.com/9082b5bfe485e5389efea4c292b509ebf6bdd6e6 Cr-Commit-Position: refs/heads/master@{#292127}

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+4 lines, -407 lines)			Patch
D	chrome/browser/google/google_util_unittest.cc	View	1 chunk	+0 lines, -407 lines	0 comments	Download
M	chrome/chrome_tests_unit.gypi	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	components/components_tests.gyp	View	3 chunks	+5 lines, -0 lines	0 comments	Download
A +	components/google/core/browser/google_util_unittest.cc	View	0 chunks	+-1 lines, --1 lines	0 comments	Download

Total messages: 7 (0 generated)

blundell

blundell@chromium.org changed reviewers: + pkasting@chromium.org

6 years, 3 months ago (2014-08-26 14:48:00 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/blundell@chromium.org/506863003/1

6 years, 3 months ago (2014-08-27 08:36:57 UTC) #5

commit-bot: I haz the power

Committed patchset #1 (1) as 727f7c848fe7354550e7faab36edeee9e3b0f38f

6 years, 3 months ago (2014-08-27 09:22:46 UTC) #6

commit-bot: I haz the power

6 years, 3 months ago (2014-09-10 02:50:46 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/9082b5bfe485e5389efea4c292b509ebf6bdd6e6
Cr-Commit-Position: refs/heads/master@{#292127}