Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(723)

Issue 506813002: Fix overzealous CHECK in custom EC_KEYs. (Closed)

Created:
6 years, 4 months ago by davidben
Modified:
6 years, 3 months ago
Reviewers:
agl
CC:
chromium-reviews, cbentzel+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Fix overzealous CHECK in custom EC_KEYs. If any EC_KEY with EX_DATA is duplicated, whether or not it is one of ours, ExDataDup may get called. This is unlikely to ever happen (I don't think we ever dup any EC_KEY on the client, and dup_ex_data has a fast-path if the EX_DATA has never been touched anyway), but the CHECK is a little overzealous. BUG=none Committed: https://crrev.com/22c8bddb6fa6b1c11960989a175f95d363119e6d Cr-Commit-Position: refs/heads/master@{#292210}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M net/android/keystore_openssl.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/ssl/openssl_platform_key_mac.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
davidben
davidben@chromium.org changed reviewers: + agl@chromium.org
6 years, 4 months ago (2014-08-26 01:00:04 UTC) #1
davidben
It'd be nice if we could somehow remove the need to ever dup an EX_DATA, ...
6 years, 4 months ago (2014-08-26 01:00:04 UTC) #2
agl
lgtm
6 years, 3 months ago (2014-08-27 18:14:59 UTC) #3
davidben
The CQ bit was checked by davidben@chromium.org
6 years, 3 months ago (2014-08-27 18:15:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/davidben@chromium.org/506813002/1
6 years, 3 months ago (2014-08-27 18:15:50 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_tests_recipe on tryserver.chromium.linux ...
6 years, 3 months ago (2014-08-27 19:10:48 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as 2f64fb28a4fc3488bf12bb2f9c6b6eab1a5a2b57
6 years, 3 months ago (2014-08-27 20:05:12 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:53:37 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/22c8bddb6fa6b1c11960989a175f95d363119e6d
Cr-Commit-Position: refs/heads/master@{#292210}

Powered by Google App Engine
This is Rietveld 408576698