Sort entries in chrome.release file.

Sort entries in chrome.release file.

BUG=NONE
TEST=NONE

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233729

[gab, 2013-11-05 16:20:29]

https://codereview.chromium.org/50673007/diff/1/chrome/installer/mini_install...
File chrome/installer/mini_installer/chrome.release (left):

https://codereview.chromium.org/50673007/diff/1/chrome/installer/mini_install...
chrome/installer/mini_installer/chrome.release:7: wow_helper.exe: %(ChromeDir)s\
So the previous logic was grouping them by target dir first.

Perhaps split those with a new line (if the script allows it...).

Despite that, some still got out of order and we should definitely fix those.

[robertshield, 2013-11-07 15:06:19]

https://codereview.chromium.org/50673007/diff/1/chrome/installer/mini_install...
File chrome/installer/mini_installer/chrome.release (left):

https://codereview.chromium.org/50673007/diff/1/chrome/installer/mini_install...
chrome/installer/mini_installer/chrome.release:7: wow_helper.exe: %(ChromeDir)s\
On 2013/11/05 16:20:30, gab wrote:
> So the previous logic was grouping them by target dir first.
> 
> Perhaps split those with a new line (if the script allows it...).
> 
> Despite that, some still got out of order and we should definitely fix those.

How about this?

[gab, 2013-11-07 16:02:18]

I'd like further grouping by subdir as well; I think it makes it easier to view
if things that land together on disk are together in this file.

https://codereview.chromium.org/50673007/diff/100001/chrome/installer/mini_in...
File chrome/installer/mini_installer/chrome.release (left):

https://codereview.chromium.org/50673007/diff/100001/chrome/installer/mini_in...
chrome/installer/mini_installer/chrome.release:47: PepperFlash\manifest.json:
%(VersionDir)s\PepperFlash\
Like it was here (until someone added widevine...dll below recently...).

https://codereview.chromium.org/50673007/diff/100001/chrome/installer/mini_in...
File chrome/installer/mini_installer/chrome.release (right):

https://codereview.chromium.org/50673007/diff/100001/chrome/installer/mini_in...
chrome/installer/mini_installer/chrome.release:19:
default_apps\external_extensions.json: %(VersionDir)s\default_apps\
I think it would be nice for subdirs like \default_apps, \Extensions, \Locales,
etc. to be grouped as well.

[robertshield, 2013-11-07 17:09:40]

https://codereview.chromium.org/50673007/diff/100001/chrome/installer/mini_in...
File chrome/installer/mini_installer/chrome.release (right):

https://codereview.chromium.org/50673007/diff/100001/chrome/installer/mini_in...
chrome/installer/mini_installer/chrome.release:19:
default_apps\external_extensions.json: %(VersionDir)s\default_apps\
On 2013/11/07 16:02:18, gab wrote:
> I think it would be nice for subdirs like \default_apps, \Extensions,
\Locales,
> etc. to be grouped as well.

Regrouped all subdirs together at the bottom.

[gab, 2013-11-07 17:48:23]

<3

https://codereview.chromium.org/50673007/diff/160001/chrome/installer/mini_in...
File chrome/installer/mini_installer/chrome.release (right):

https://codereview.chromium.org/50673007/diff/160001/chrome/installer/mini_in...
chrome/installer/mini_installer/chrome.release:55:
PepperFlash\pepflashplayer.dll: %(VersionDir)s\PepperFlash\
Also split these by subfolder :)

[robertshield, 2013-11-07 18:07:58]

ptal

[gab, 2013-11-07 18:22:43]

lgtm with <3!

[commit-bot: I haz the power, 2013-11-07 18:27:05]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/robertshield@chromium.org/50673007/210001

[commit-bot: I haz the power, 2013-11-08 00:39:01]

Change committed as 233729