Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(999)

Unified Diff: media/formats/webm/webm_cluster_parser.cc

Issue 506683002: Remove implicit conversions from scoped_refptr to T* in media/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/formats/webm/webm_cluster_parser.cc
diff --git a/media/formats/webm/webm_cluster_parser.cc b/media/formats/webm/webm_cluster_parser.cc
index e563a8ef5053e9840825189c94add9824e08e8e9..6cb51c82238c6bb2f24bdee1eb4521ba8fa8a3b2 100644
--- a/media/formats/webm/webm_cluster_parser.cc
+++ b/media/formats/webm/webm_cluster_parser.cc
@@ -441,7 +441,7 @@ WebMClusterParser::Track::~Track() {}
DecodeTimestamp WebMClusterParser::Track::GetReadyUpperBound() {
DCHECK(ready_buffers_.empty());
- if (last_added_buffer_missing_duration_)
+ if (last_added_buffer_missing_duration_.get())
return last_added_buffer_missing_duration_->GetDecodeTimestamp();
return DecodeTimestamp::FromPresentationTime(base::TimeDelta::Max());
@@ -489,7 +489,7 @@ bool WebMClusterParser::Track::AddBuffer(
<< " kf " << buffer->IsKeyframe()
<< " size " << buffer->data_size();
- if (last_added_buffer_missing_duration_) {
+ if (last_added_buffer_missing_duration_.get()) {
base::TimeDelta derived_duration =
buffer->timestamp() - last_added_buffer_missing_duration_->timestamp();
last_added_buffer_missing_duration_->set_duration(derived_duration);
@@ -518,7 +518,7 @@ bool WebMClusterParser::Track::AddBuffer(
}
void WebMClusterParser::Track::ApplyDurationEstimateIfNeeded() {
- if (!last_added_buffer_missing_duration_)
+ if (!last_added_buffer_missing_duration_.get())
return;
last_added_buffer_missing_duration_->set_duration(GetDurationEstimate());
@@ -574,7 +574,7 @@ bool WebMClusterParser::Track::IsKeyframe(const uint8* data, int size) const {
bool WebMClusterParser::Track::QueueBuffer(
const scoped_refptr<StreamParserBuffer>& buffer) {
- DCHECK(!last_added_buffer_missing_duration_);
+ DCHECK(!last_added_buffer_missing_duration_.get());
// WebMClusterParser::OnBlock() gives MEDIA_LOG and parse error on decreasing
// block timecode detection within a cluster. Therefore, we should not see

Powered by Google App Engine
This is Rietveld 408576698