media/filters/video_renderer_impl.cc - Issue 506683002: Remove implicit conversions from scoped_refptr to T* in media/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/filters/video_renderer_impl.cc

Issue 506683002: Remove implicit conversions from scoped_refptr to T* in media/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« media/cast/test/utility/udp_proxy.cc ('K') | « media/filters/source_buffer_stream.cc ('k') | media/filters/video_renderer_impl_unittest.cc » ('j') | media/filters/vpx_video_decoder.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: media/filters/video_renderer_impl.cc

diff --git a/media/filters/video_renderer_impl.cc b/media/filters/video_renderer_impl.cc

index 6866855495fed088290be3616616fb63d80fb42a..f13ff01b0cd573ac58ccbd2f6f111cf7bae687c8 100644

--- a/media/filters/video_renderer_impl.cc

+++ b/media/filters/video_renderer_impl.cc

@@ -322,7 +322,7 @@ void VideoRendererImpl::FrameReady(VideoFrameStream::Status status,

DCHECK_EQ(state_, kPlaying);

// Can happen when demuxers are preparing for a new Seek().

- if (!frame) {

+ if (!frame.get()) {

DCHECK_EQ(status, VideoFrameStream::DEMUXER_READ_ABORTED);

return;

}

« media/cast/test/utility/udp_proxy.cc ('K') | « media/filters/source_buffer_stream.cc ('k') | media/filters/video_renderer_impl_unittest.cc » ('j') | media/filters/vpx_video_decoder.cc » ('J')