Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1304)

Unified Diff: media/filters/audio_renderer_impl.cc

Issue 506683002: Remove implicit conversions from scoped_refptr to T* in media/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/filters/audio_renderer_impl.cc
diff --git a/media/filters/audio_renderer_impl.cc b/media/filters/audio_renderer_impl.cc
index fddb7ae46a05c78c37ac8cc899d65a8bd67c3a6d..9387de981240233fc4a0262a95196446dd235edc 100644
--- a/media/filters/audio_renderer_impl.cc
+++ b/media/filters/audio_renderer_impl.cc
@@ -254,7 +254,7 @@ void AudioRendererImpl::Initialize(DemuxerStream* stream,
DCHECK(!ended_cb.is_null());
DCHECK(!error_cb.is_null());
DCHECK_EQ(kUninitialized, state_);
- DCHECK(sink_);
+ DCHECK(sink_.get());
state_ = kInitializing;
@@ -356,7 +356,7 @@ void AudioRendererImpl::OnAudioBufferStreamInitialized(bool success) {
void AudioRendererImpl::SetVolume(float volume) {
DCHECK(task_runner_->BelongsToCurrentThread());
- DCHECK(sink_);
+ DCHECK(sink_.get());
sink_->SetVolume(volume);
}
@@ -510,7 +510,7 @@ void AudioRendererImpl::SetPlaybackRate(float playback_rate) {
DVLOG(1) << __FUNCTION__ << "(" << playback_rate << ")";
DCHECK(task_runner_->BelongsToCurrentThread());
DCHECK_GE(playback_rate, 0);
- DCHECK(sink_);
+ DCHECK(sink_.get());
base::AutoLock auto_lock(lock_);
@@ -537,7 +537,7 @@ void AudioRendererImpl::SetPlaybackRate(float playback_rate) {
bool AudioRendererImpl::IsBeforeStartTime(
const scoped_refptr<AudioBuffer>& buffer) {
DCHECK_EQ(state_, kPlaying);
- return buffer && !buffer->end_of_stream() &&
+ return buffer.get() && !buffer->end_of_stream() &&
(buffer->timestamp() + buffer->duration()) < start_timestamp_;
}

Powered by Google App Engine
This is Rietveld 408576698