Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Side by Side Diff: media/filters/fake_video_decoder_unittest.cc

Issue 506683002: Remove implicit conversions from scoped_refptr to T* in media/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/basictypes.h" 5 #include "base/basictypes.h"
6 #include "base/bind.h" 6 #include "base/bind.h"
7 #include "base/message_loop/message_loop.h" 7 #include "base/message_loop/message_loop.h"
8 #include "media/base/decoder_buffer.h" 8 #include "media/base/decoder_buffer.h"
9 #include "media/base/mock_filters.h" 9 #include "media/base/mock_filters.h"
10 #include "media/base/test_helpers.h" 10 #include "media/base/test_helpers.h"
(...skipping 74 matching lines...) Expand 10 before | Expand all | Expand 10 after
85 }; 85 };
86 86
87 void ExpectReadResult(CallbackResult result) { 87 void ExpectReadResult(CallbackResult result) {
88 switch (result) { 88 switch (result) {
89 case PENDING: 89 case PENDING:
90 EXPECT_GT(pending_decode_requests_, 0); 90 EXPECT_GT(pending_decode_requests_, 0);
91 break; 91 break;
92 case OK: 92 case OK:
93 EXPECT_EQ(0, pending_decode_requests_); 93 EXPECT_EQ(0, pending_decode_requests_);
94 ASSERT_EQ(VideoDecoder::kOk, last_decode_status_); 94 ASSERT_EQ(VideoDecoder::kOk, last_decode_status_);
95 ASSERT_TRUE(last_decoded_frame_); 95 ASSERT_TRUE(last_decoded_frame_.get());
96 break; 96 break;
97 case NOT_ENOUGH_DATA: 97 case NOT_ENOUGH_DATA:
98 EXPECT_EQ(0, pending_decode_requests_); 98 EXPECT_EQ(0, pending_decode_requests_);
99 ASSERT_EQ(VideoDecoder::kOk, last_decode_status_); 99 ASSERT_EQ(VideoDecoder::kOk, last_decode_status_);
100 ASSERT_FALSE(last_decoded_frame_); 100 ASSERT_FALSE(last_decoded_frame_.get());
101 break; 101 break;
102 case ABORTED: 102 case ABORTED:
103 EXPECT_EQ(0, pending_decode_requests_); 103 EXPECT_EQ(0, pending_decode_requests_);
104 ASSERT_EQ(VideoDecoder::kAborted, last_decode_status_); 104 ASSERT_EQ(VideoDecoder::kAborted, last_decode_status_);
105 EXPECT_FALSE(last_decoded_frame_); 105 EXPECT_FALSE(last_decoded_frame_.get());
106 break; 106 break;
107 } 107 }
108 } 108 }
109 109
110 void Decode() { 110 void Decode() {
111 scoped_refptr<DecoderBuffer> buffer; 111 scoped_refptr<DecoderBuffer> buffer;
112 112
113 if (num_input_buffers_ < kTotalBuffers) { 113 if (num_input_buffers_ < kTotalBuffers) {
114 buffer = CreateFakeVideoBufferForTest( 114 buffer = CreateFakeVideoBufferForTest(
115 current_config_, 115 current_config_,
116 base::TimeDelta::FromMilliseconds(kDurationMs * num_input_buffers_), 116 base::TimeDelta::FromMilliseconds(kDurationMs * num_input_buffers_),
117 base::TimeDelta::FromMilliseconds(kDurationMs)); 117 base::TimeDelta::FromMilliseconds(kDurationMs));
118 } else { 118 } else {
119 buffer = DecoderBuffer::CreateEOSBuffer(); 119 buffer = DecoderBuffer::CreateEOSBuffer();
120 } 120 }
121 121
122 ++num_input_buffers_; 122 ++num_input_buffers_;
123 ++pending_decode_requests_; 123 ++pending_decode_requests_;
124 124
125 decoder_->Decode( 125 decoder_->Decode(
126 buffer, 126 buffer,
127 base::Bind(&FakeVideoDecoderTest::DecodeDone, base::Unretained(this))); 127 base::Bind(&FakeVideoDecoderTest::DecodeDone, base::Unretained(this)));
128 message_loop_.RunUntilIdle(); 128 message_loop_.RunUntilIdle();
129 } 129 }
130 130
131 void ReadOneFrame() { 131 void ReadOneFrame() {
132 last_decoded_frame_ = NULL; 132 last_decoded_frame_ = NULL;
133 do { 133 do {
134 Decode(); 134 Decode();
135 } while (!last_decoded_frame_ && pending_decode_requests_ == 0); 135 } while (!last_decoded_frame_.get() && pending_decode_requests_ == 0);
136 } 136 }
137 137
138 void ReadAllFrames() { 138 void ReadAllFrames() {
139 do { 139 do {
140 Decode(); 140 Decode();
141 } while (num_input_buffers_ <= kTotalBuffers); // All input buffers + EOS. 141 } while (num_input_buffers_ <= kTotalBuffers); // All input buffers + EOS.
142 } 142 }
143 143
144 void EnterPendingReadState() { 144 void EnterPendingReadState() {
145 // Pass the initial NOT_ENOUGH_DATA stage. 145 // Pass the initial NOT_ENOUGH_DATA stage.
(...skipping 121 matching lines...) Expand 10 before | Expand all | Expand 10 after
267 if (GetParam().decoding_delay < 1) 267 if (GetParam().decoding_delay < 1)
268 return; 268 return;
269 269
270 Initialize(); 270 Initialize();
271 decoder_->HoldDecode(); 271 decoder_->HoldDecode();
272 ReadOneFrame(); 272 ReadOneFrame();
273 ExpectReadResult(PENDING); 273 ExpectReadResult(PENDING);
274 SatisfyDecodeAndExpect(NOT_ENOUGH_DATA); 274 SatisfyDecodeAndExpect(NOT_ENOUGH_DATA);
275 275
276 // Verify that FrameReady() hasn't been called. 276 // Verify that FrameReady() hasn't been called.
277 EXPECT_FALSE(last_decoded_frame_); 277 EXPECT_FALSE(last_decoded_frame_.get());
278 } 278 }
279 279
280 TEST_P(FakeVideoDecoderTest, Read_Pending_OK) { 280 TEST_P(FakeVideoDecoderTest, Read_Pending_OK) {
281 Initialize(); 281 Initialize();
282 EnterPendingReadState(); 282 EnterPendingReadState();
283 SatisfyDecodeAndExpect(OK); 283 SatisfyDecodeAndExpect(OK);
284 } 284 }
285 285
286 TEST_P(FakeVideoDecoderTest, Read_Parallel) { 286 TEST_P(FakeVideoDecoderTest, Read_Parallel) {
287 if (GetParam().max_decode_requests < 2) 287 if (GetParam().max_decode_requests < 2)
(...skipping 102 matching lines...) Expand 10 before | Expand all | Expand 10 after
390 } 390 }
391 391
392 TEST_P(FakeVideoDecoderTest, Destroy_DuringPendingReadAndPendingReset) { 392 TEST_P(FakeVideoDecoderTest, Destroy_DuringPendingReadAndPendingReset) {
393 Initialize(); 393 Initialize();
394 EnterPendingReadState(); 394 EnterPendingReadState();
395 EnterPendingResetState(); 395 EnterPendingResetState();
396 Destroy(); 396 Destroy();
397 } 397 }
398 398
399 } // namespace media 399 } // namespace media
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698