tools/metrics/histograms/histograms.xml - Issue 506663003: Consolidates accessing and setting the UMA pref to be within metrics code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/metrics/histograms/histograms.xml

Issue 506663003: Consolidates accessing and setting the UMA pref to be within metrics code (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: MetricsReporting handling moved to browser_options_handler. JS callback is not called if the… Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Download patch

Index: tools/metrics/histograms/histograms.xml

diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml

index 57cf2870374239a36267d9e56c954da44c72c716..bf1a5987b1d83efb2cc6935840b1cb2e0f9e0029 100644

--- a/tools/metrics/histograms/histograms.xml

+++ b/tools/metrics/histograms/histograms.xml

@@ -34892,6 +34892,13 @@ Therefore, the affected-histogram name has to have at least one dot in it.

</summary>

</histogram>

+<histogram name="UMA.MetricsReporting" enum="MetricsReportingChange">

+ <owner>asvitkine@chromium.org</owner>

+ <summary>

+ Log whether MetricsReporting is enabled.

+ </summary>

+</histogram>

<histogram name="UpdateEngine.Attempt.ConnectionType"

enum="UpdateEngineConnectionType">

<owner>zeuthen@chromium.org</owner>

@@ -51596,6 +51603,11 @@ To add a new entry, add it with any value and run test to compute valid value.

</enum>

+<enum name="MetricsReportingChange" type="int">

+ <int value="0" label="MetricsReporting is disabled"/>

+ <int value="1" label="MetricsReporting is enabled"/>

+</enum>

</enums>

« chrome/browser/ui/webui/options/browser_options_handler.cc ('K') | « components/metrics/metrics_state_manager.cc ('k') | no next file » | no next file with comments »