chrome/browser/ui/webui/options/core_options_handler.h - Issue 506663003: Consolidates accessing and setting the UMA pref to be within metrics code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/options/core_options_handler.h

Issue 506663003: Consolidates accessing and setting the UMA pref to be within metrics code (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: more comments. using accesor class. Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/webui/options/browser_options_handler.cc ('K') | « chrome/browser/ui/webui/options/browser_options_handler.cc ('k') | chrome/browser/ui/webui/options/core_options_handler.cc » ('j') | chrome/browser/ui/webui/options/core_options_handler.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/options/core_options_handler.h

diff --git a/chrome/browser/ui/webui/options/core_options_handler.h b/chrome/browser/ui/webui/options/core_options_handler.h

index 5976d49cd3b286884a2beecd9c74a79de70142ec..43526e105dc7da28c7492aeda6fdf4f92850497f 100644

--- a/chrome/browser/ui/webui/options/core_options_handler.h

+++ b/chrome/browser/ui/webui/options/core_options_handler.h

@@ -160,6 +160,12 @@ class CoreOptionsHandler : public OptionsPageUIHandler {

// only argument in the |args| list.

void HandleDisableExtension(const base::ListValue* args);

+ // Passes forward the request to change MetricsReportingEnabled.

+ void HandleMetricsReportingChange(const base::ListValue* args);

+ // Notifies the result of MetricsReportingEnabled change to Javascript layer.

+ void MetricsReportingChangeCallback(bool success);

void UpdateClearPluginLSOData();

void UpdatePepperFlashSettingsEnabled();