Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1190)

Unified Diff: chrome/browser/metrics/metrics_reporting_state.h

Issue 506663003: Consolidates accessing and setting the UMA pref to be within metrics code (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: android check removed Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/metrics/metrics_reporting_state.h
diff --git a/chrome/browser/metrics/metrics_reporting_state.h b/chrome/browser/metrics/metrics_reporting_state.h
index c333d84e52b87cfbe39697c3be71c829659838a2..4716929571f674c31041ecd4567a10e1b4b4f2bb 100644
--- a/chrome/browser/metrics/metrics_reporting_state.h
+++ b/chrome/browser/metrics/metrics_reporting_state.h
@@ -5,12 +5,22 @@
#ifndef CHROME_BROWSER_METRICS_METRICS_REPORTING_STATE_H_
#define CHROME_BROWSER_METRICS_METRICS_REPORTING_STATE_H_
-// Tries to set crash stats upload consent to |enabled|. Regardless of success,
-// if crash stats uploading is enabled, starts the MetricsService; otherwise
-// stops it.
-// Returns whether crash stats uploading is enabled.
-// TODO(tfarina): This method is pretty confusing. Clean this up and rename it
-// to something that makes more sense.
-bool ResolveMetricsReportingEnabled(bool enabled);
+#include "base/callback.h"
+
+typedef base::Callback<void(bool)> OnMetricsReportingCallbackType;
+
+// Initiates a change to metrics reporting state to the new value of |enabled|.
+// Starts or stops the metrics service based on the new state and then runs
+// |callback_fn| (which can be null) with the updated state (as the operation
+// may fail). On platforms other than CrOS and Android, also updates the
+// underlying pref.
+// TODO(gayane): Support setting the pref on all platforms.
+void InitiateMetricsReportingChange(
+ bool enabled,
+ const OnMetricsReportingCallbackType& callback_fn);
+
+// Returns whether MetricsReporting can be modified by the user (except CrOS and
+// Android).
+bool IsMetricsReportingUserChangable();
#endif // CHROME_BROWSER_METRICS_METRICS_REPORTING_STATE_H_
« no previous file with comments | « chrome/browser/metrics/chrome_metrics_service_accessor.h ('k') | chrome/browser/metrics/metrics_reporting_state.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698