Consolidates accessing and setting the UMA pref to be within metrics code

chrome/browser/metrics/metrics_reporting_state.h

Index: chrome/browser/metrics/metrics_reporting_state.h
diff --git a/chrome/browser/metrics/metrics_reporting_state.h b/chrome/browser/metrics/metrics_reporting_state.h
index c333d84e52b87cfbe39697c3be71c829659838a2..bbc03d1c9460c9a2c36a3da145af4a0d07628d0e 100644
--- a/chrome/browser/metrics/metrics_reporting_state.h
+++ b/chrome/browser/metrics/metrics_reporting_state.h
@@ -5,12 +5,19 @@
 #ifndef CHROME_BROWSER_METRICS_METRICS_REPORTING_STATE_H_
 #define CHROME_BROWSER_METRICS_METRICS_REPORTING_STATE_H_
 
-// Tries to set crash stats upload consent to |enabled|. Regardless of success,
-// if crash stats uploading is enabled, starts the MetricsService; otherwise
-// stops it.
-// Returns whether crash stats uploading is enabled.
-// TODO(tfarina): This method is pretty confusing. Clean this up and rename it
-// to something that makes more sense.
-bool ResolveMetricsReportingEnabled(bool enabled);
+#include "base/callback.h"
+#include "components/metrics/metrics_service.h"
+
+
+// Initiates the necessary changes for MetricsReportingEnabled change on a
+// thread with IO access.
+void InitiateMetricsReportingChange(bool enabled,
+                                    base::Callback<void(bool)> callback_fn);
+
+// Returns weather MetricsReporting is checked.
+bool IsMetricsReportingEnabled();

[Alexei Svitkine (slow), 2014/09/04 18:45:26]

Hmm, why not just use the version from ChromeMetricsServiceAccessor instead of
having another function?

[gayane -on leave until 09-2017, 2014/09/04 21:30:12]

Do you want to move IsMetricsReportingUserChangable to Accessor?

+
+// Returns weather MetricsReporting can be modified by user.
+bool IsMetricsReportingUserChangable();
 
 #endif  // CHROME_BROWSER_METRICS_METRICS_REPORTING_STATE_H_