chrome/browser/ui/views/session_crashed_bubble_view.cc - Issue 506663003: Consolidates accessing and setting the UMA pref to be within metrics code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/session_crashed_bubble_view.cc

Issue 506663003: Consolidates accessing and setting the UMA pref to be within metrics code (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fixes, more comments Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/metrics/metrics_reporting_state.cc ('K') | « chrome/browser/resources/options/browser_options.js ('k') | chrome/browser/ui/webui/options/browser_options_handler.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/session_crashed_bubble_view.cc

diff --git a/chrome/browser/ui/views/session_crashed_bubble_view.cc b/chrome/browser/ui/views/session_crashed_bubble_view.cc

index acc8e84fd230783b8a7ae42c73b38f0593408ece..6b4c2e6a24c0f1a2a65af7bb66bd7de64b667cd3 100644

--- a/chrome/browser/ui/views/session_crashed_bubble_view.cc

+++ b/chrome/browser/ui/views/session_crashed_bubble_view.cc

@@ -423,11 +423,8 @@ void SessionCrashedBubbleView::RestorePreviousSession(views::Button* sender) {

// Record user's choice for opting in to UMA.

// There's no opting-out choice in the crash restore bubble.

if (uma_option_ && uma_option_->checked()) {

- // TODO: Clean up function ResolveMetricsReportingEnabled so that user pref

- // is stored automatically.

- ResolveMetricsReportingEnabled(true);

- g_browser_process->local_state()->SetBoolean(

- prefs::kMetricsReportingEnabled, true);

+ base::Callback<void(bool)> callback_fn;

+ InitiateMetricsReportingChange(true, callback_fn);

RecordBubbleHistogramValue(SESSION_CRASHED_BUBBLE_UMA_OPTIN);

}

CloseBubble();