chrome/browser/metrics/chrome_metrics_service_accessor.h - Issue 506663003: Consolidates accessing and setting the UMA pref to be within metrics code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/metrics/chrome_metrics_service_accessor.h

Issue 506663003: Consolidates accessing and setting the UMA pref to be within metrics code (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fixes, more comments Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/preference/preference_api.cc ('k') | chrome/browser/metrics/metrics_reporting_state.h » ('j') | chrome/browser/metrics/metrics_reporting_state.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/metrics/chrome_metrics_service_accessor.h

diff --git a/chrome/browser/metrics/chrome_metrics_service_accessor.h b/chrome/browser/metrics/chrome_metrics_service_accessor.h

index d64f4c6f561b026279bdb10238c57bc454bfee61..c21a5475507f030126d77ae48a5666c3855253ac 100644

--- a/chrome/browser/metrics/chrome_metrics_service_accessor.h

+++ b/chrome/browser/metrics/chrome_metrics_service_accessor.h

@@ -11,6 +11,7 @@

#include "base/gtest_prod_util.h"

#include "base/macros.h"

#include "chrome/browser/metrics/metrics_service_accessor.h"

+#include "chrome/browser/ui/webui/options/browser_options_handler.h"

Alexei Svitkine (slow) 2014/09/11 17:17:51 Please forward declare the class instead.

gayane -on leave until 09-2017 2014/09/11 19:04:10 Done.

class Profile;

@@ -48,6 +49,9 @@ class ChromeMetricsServiceAccessor : public MetricsServiceAccessor {

friend class ::FlashDOMHandler;

friend class system_logs::ChromeInternalLogSource;

friend class UmaSessionStats;

+ friend class options::BrowserOptionsHandler;

+ friend void InitiateMetricsReportingChange(bool,

+ const base::Callback<void(bool)>);

FRIEND_TEST_ALL_PREFIXES(ChromeMetricsServiceAccessorTest,

MetricsReportingEnabled);