Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Unified Diff: chrome/browser/resources/options/browser_options.js

Issue 506663003: Consolidates accessing and setting the UMA pref to be within metrics code (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: minor changes and fixes Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/options/browser_options.js
diff --git a/chrome/browser/resources/options/browser_options.js b/chrome/browser/resources/options/browser_options.js
index c7bcb147c8cd40ab170006dd21461063323f6249..4fb58b06634212a40cb59321276b93df56f77f39 100644
--- a/chrome/browser/resources/options/browser_options.js
+++ b/chrome/browser/resources/options/browser_options.js
@@ -383,14 +383,19 @@ cr.define('options', function() {
restartElements[1].onclick = function(event) {
chrome.send('restartBrowser');
};
+ // Attach the listener for updating the checkbox and restart button.
var updateMetricsRestartButton = function() {
$('metrics-reporting-reset-restart').hidden =
loadTimeData.getBoolean('metricsReportingEnabledAtStart') ==
$('metricsReportingEnabled').checked;
};
- Preferences.getInstance().addEventListener(
- $('metricsReportingEnabled').getAttribute('pref'),
- updateMetricsRestartButton);
+ $('metricsReportingEnabled').onclick = function(event) {
+ chrome.send('metricsReportingCheckboxChanged',
+ [Boolean(event.currentTarget.checked)]);
+ updateMetricsRestartButton();
+ };
+ $('metricsReportingEnabled').checked =
+ loadTimeData.getBoolean('metricsReportingEnabledAtStart');
updateMetricsRestartButton();
}
$('networkPredictionOptions').onchange = function(event) {
@@ -1515,6 +1520,13 @@ cr.define('options', function() {
setMetricsReportingCheckboxState_: function(checked, disabled) {
$('metricsReportingEnabled').checked = checked;
$('metricsReportingEnabled').disabled = disabled;
+
+ // if checkbox gets disabled then add an attribute for displaying the
Alexei Svitkine (slow) 2014/09/11 15:33:43 Nit: Capitalize if.
gayane -on leave until 09-2017 2014/09/11 17:06:08 Done.
+ // special icon. The opposite shouldn't be possible to do.
+ if (disabled) {
+ $('metrics-reporting-disabled-icon').setAttribute('controlled-by',
+ 'policy');
+ }
},
/**

Powered by Google App Engine
This is Rietveld 408576698