chrome/browser/resources/options/browser_options.html - Issue 506663003: Consolidates accessing and setting the UMA pref to be within metrics code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/options/browser_options.html

Issue 506663003: Consolidates accessing and setting the UMA pref to be within metrics code (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Always pass all params to setMetricsReportingCheckboxState, minor changes Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/metrics/metrics_reporting_state.cc ('K') | « chrome/browser/policy/configuration_policy_handler_list_factory.cc ('k') | chrome/browser/resources/options/browser_options.js » ('j') | chrome/browser/resources/options/browser_options.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/options/browser_options.html

diff --git a/chrome/browser/resources/options/browser_options.html b/chrome/browser/resources/options/browser_options.html

index 3e4d58c285460cc881e4c2043ff95df8b3259cac..23b9b47f0f557583b12d9d07707ebad84d753d99 100644

--- a/chrome/browser/resources/options/browser_options.html

+++ b/chrome/browser/resources/options/browser_options.html

@@ -356,12 +356,11 @@

</if>

<label>

- <input id="metricsReportingEnabled"

- pref="user_experience_metrics.reporting_enabled" type="checkbox">

+ <input id="metricsReportingEnabled" type="checkbox">

</label>

- <span class="controlled-setting-indicator"

- pref="user_experience_metrics.reporting_enabled">

+ <span id="metrics-reporting-disabled-icon"

+ class="controlled-setting-indicator">

</span>