tools/metrics/histograms/histograms.xml - Issue 506663003: Consolidates accessing and setting the UMA pref to be within metrics code

Unified Diff: tools/metrics/histograms/histograms.xml

Issue 506663003: Consolidates accessing and setting the UMA pref to be within metrics code (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Return updated state instead of success identifier + minor changes Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Download patch

Index: tools/metrics/histograms/histograms.xml

diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml

index 57cf2870374239a36267d9e56c954da44c72c716..92362d762ed5a05c843819f70990a7d78c5e3462 100644

--- a/tools/metrics/histograms/histograms.xml

+++ b/tools/metrics/histograms/histograms.xml

@@ -34892,6 +34892,13 @@ Therefore, the affected-histogram name has to have at least one dot in it.

</summary>

</histogram>

+<histogram name="UMA.MetricsReporting" enum="MetricsReportingChange">

Alexei Svitkine (slow) 2014/09/09 15:27:16 I'd use use a name that suggests the action the us

gayane -on leave until 09-2017 2014/09/09 19:40:51 Done.

+ <owner>asvitkine@chromium.org</owner>

+ <summary>

+ Log whether MetricsReporting is enabled.

Alexei Svitkine (slow) 2014/09/09 15:27:16 I would expand this description and make it cleare

gayane -on leave until 09-2017 2014/09/09 19:40:51 Done.

+ </summary>

+</histogram>

<histogram name="UpdateEngine.Attempt.ConnectionType"

enum="UpdateEngineConnectionType">

<owner>zeuthen@chromium.org</owner>

@@ -51596,6 +51603,12 @@ To add a new entry, add it with any value and run test to compute valid value.

</enum>

+<enum name="MetricsReportingChange" type="int">

+ <int value="0" label="Error while updating MetricsReporting state"/>

+ <int value="1" label="MetricsReporting is disabled"/>

Alexei Svitkine (slow) 2014/09/09 15:27:16 Nit: I'd use shorter strings here (e.g. Error, Dis

gayane -on leave until 09-2017 2014/09/09 19:40:52 Done.

+ <int value="2" label="MetricsReporting is enabled"/>

+</enum>

</enums>

« chrome/browser/ui/webui/options/browser_options_handler.cc ('K') | « components/metrics/metrics_state_manager.cc ('k') | no next file » | no next file with comments »