chrome/browser/resources/options/browser_options.html - Issue 506663003: Consolidates accessing and setting the UMA pref to be within metrics code

Side by Side Diff: chrome/browser/resources/options/browser_options.html

Issue 506663003: Consolidates accessing and setting the UMA pref to be within metrics code (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: MetricsReporting handling moved to browser_options_handler. JS callback is not called if the… Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/metrics/metrics_reporting_state.cc ('K') | « chrome/browser/policy/configuration_policy_handler_list_factory.cc ('k') | chrome/browser/resources/options/browser_options.js » ('j') | chrome/browser/ui/webui/options/browser_options_handler.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <div id="settings" class="page" hidden>	1 <div id="settings" class="page" hidden>

2 <header>	2 <header>

3 <h1 i18n-content="settingsTitle"></h1>	3 <h1 i18n-content="settingsTitle"></h1>

4 </header>	4 </header>

5 <include src="automatic_settings_reset_banner.html">	5 <include src="automatic_settings_reset_banner.html">

6 <if expr="chromeos">	6 <if expr="chromeos">

7 <include src="secondary_user_banner.html">	7 <include src="secondary_user_banner.html">

8 <section>	8 <section>

9 <div id="network-section-header" class="section-header">	9 <div id="network-section-header" class="section-header">

10 <h3 i18n-content="sectionTitleInternet"></h3>	10 <h3 i18n-content="sectionTitleInternet"></h3>

(...skipping 338 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
349 <label>	349 <label>

350 <input id="metricsReportingEnabled"	350 <input id="metricsReportingEnabled"

351 pref="cros.metrics.reportingEnabled" type="checkbox">	351 pref="cros.metrics.reportingEnabled" type="checkbox">

352 <span i18n-content="enableLogging"></span>	352 <span i18n-content="enableLogging"></span>

353 </label>	353 </label>

354 <span class="controlled-setting-indicator"	354 <span class="controlled-setting-indicator"

355 pref="cros.metrics.reportingEnabled"></span>	355 pref="cros.metrics.reportingEnabled"></span>

356 </if>	356 </if>

357 <if expr="not chromeos">	357 <if expr="not chromeos">

358 <label>	358 <label>

359 <input id="metricsReportingEnabled"	359 <input id="metricsReportingEnabled" type="checkbox">

360 pref="user_experience_metrics.reporting_enabled" type="checkbox">

361 <span i18n-content="enableLogging">	360 <span i18n-content="enableLogging">

362 </label>	361 </label>

363 <span class="controlled-setting-indicator"	362 <span class="controlled-setting-indicator">

364 pref="user_experience_metrics.reporting_enabled">

365 </span>	363 </span>

366 <span id="metrics-reporting-reset-restart">	364 <span id="metrics-reporting-reset-restart">

367 <!-- Text filled by JavaScript -->	365 <!-- Text filled by JavaScript -->

368 <span></span><button class=	366 <span></span><button class=

369 "link-button standalone-link-button"></button><span></span>	367 "link-button standalone-link-button"></button><span></span>

370 </span>	368 </span>

371 </if>	369 </if>

372 </div>	370 </div>

373 </if> <!-- _google_chrome -->	371 </if> <!-- _google_chrome -->

374 <div class="checkbox">	372 <div class="checkbox">

(...skipping 492 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
867 <button id="advanced-settings-expander" class="link-button"	865 <button id="advanced-settings-expander" class="link-button"

868 i18n-content="showAdvancedSettings">	866 i18n-content="showAdvancedSettings">

869 </button>	867 </button>

870 <if expr="chromeos">	868 <if expr="chromeos">

871 <button id="version-button" class="link-button" hidden	869 <button id="version-button" class="link-button" hidden

872 i18n-content="browserVersion">	870 i18n-content="browserVersion">

873 </button>	871 </button>

874 </if>	872 </if>

875 </footer>	873 </footer>

876 </div>	874 </div>

OLD	NEW