chrome/browser/metrics/metrics_reporting_state.h - Issue 506663003: Consolidates accessing and setting the UMA pref to be within metrics code

Side by Side Diff: chrome/browser/metrics/metrics_reporting_state.h

Issue 506663003: Consolidates accessing and setting the UMA pref to be within metrics code (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: MetricsReporting handling moved to browser_options_handler. JS callback is not called if the… Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/chromeos/login/wizard_controller.cc ('K') | « chrome/browser/metrics/chrome_metrics_service_accessor.h ('k') | chrome/browser/metrics/metrics_reporting_state.cc » ('j') | chrome/browser/metrics/metrics_reporting_state.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef CHROME_BROWSER_METRICS_METRICS_REPORTING_STATE_H_	5 #ifndef CHROME_BROWSER_METRICS_METRICS_REPORTING_STATE_H_

6 #define CHROME_BROWSER_METRICS_METRICS_REPORTING_STATE_H_	6 #define CHROME_BROWSER_METRICS_METRICS_REPORTING_STATE_H_

7	7

8 // Tries to set crash stats upload consent to \|enabled\|. Regardless of success,	8 #include "base/callback.h"

9 // if crash stats uploading is enabled, starts the MetricsService; otherwise	9 #include "components/metrics/metrics_service.h"

10 // stops it.	10

11 // Returns whether crash stats uploading is enabled.	11

12 // TODO(tfarina): This method is pretty confusing. Clean this up and rename it	12 // Initiates the necessary changes for MetricsReportingEnabled change on a

13 // to something that makes more sense.	13 // thread with IO access. The parameter \|enabled\| indicates whether

14 bool ResolveMetricsReportingEnabled(bool enabled);	14 // MetricsReportingEnabled should be true or false and \|callback_fn\| is a
	Alexei Svitkine (slow) 2014/09/05 20:50:25 How about this wording which also talks about metr How about this wording which also talks about metrics service: // Initiates a change to metrics reporting state to the new value of \|enabled\|. // Starts or stops the metrics service based on the new state and then runs // \|callback_fn\| (which can be null) with the updated state (as the operation // may fail). On platforms other than CrOS and Android, also updates the // underlying pref. // TODO(gayane): Support setting the pref on all platforms. gayane -on leave until 09-2017 2014/09/08 18:32:46 Done. On 2014/09/05 20:50:25, Alexei Svitkine wro Done. On 2014/09/05 20:50:25, Alexei Svitkine wrote: Show quoted text > How about this wording which also talks about metrics service: > > // Initiates a change to metrics reporting state to the new value of \|enabled\|. > // Starts or stops the metrics service based on the new state and then runs > // \|callback_fn\| (which can be null) with the updated state (as the operation > // may fail). On platforms other than CrOS and Android, also updates the > // underlying pref. > // TODO(gayane): Support setting the pref on all platforms.
	15 // reference to a callback function which will be called with a success status.

	16 // \|callback_fn\| can be null.

	17 // TODO(gayane) Currently this function doesn't change the preference for CrOS.
	Alexei Svitkine (slow) 2014/09/05 20:50:25 Mention that it doesn't support Android either. (B Mention that it doesn't support Android either. (But this is OK since Android doesn't call this since it has its own settings page.) Also, add a : after the TODO(gayane) (This is addressed in my suggestion above for the wording.) gayane -on leave until 09-2017 2014/09/08 18:32:46 Acknowledged. Show quoted text On 2014/09/05 20:50:25, Alexei Svitkine wrote: > Mention that it doesn't support Android either. (But this is OK since Android > doesn't call this since it has its own settings page.) > > Also, add a : after the TODO(gayane) > > (This is addressed in my suggestion above for the wording.) Acknowledged.
	18 void InitiateMetricsReportingChange(bool enabled,

	19 base::Callback<void(bool)> callback_fn);

	20

	21 // Returns whether MetricsReporting can be modified by the user.

	22 bool IsMetricsReportingUserChangable();

15	23

16 #endif // CHROME_BROWSER_METRICS_METRICS_REPORTING_STATE_H_	24 #endif // CHROME_BROWSER_METRICS_METRICS_REPORTING_STATE_H_

OLD	NEW