Consolidates accessing and setting the UMA pref to be within metrics code

chrome/browser/resources/options/browser_options.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('options', function() {
   var OptionsPage = options.OptionsPage;
   var Page = cr.ui.pageManager.Page;
   var PageManager = cr.ui.pageManager.PageManager;
   var ArrayDataModel = cr.ui.ArrayDataModel;
   var RepeatingButton = cr.ui.RepeatingButton;
@@ skipping 20 matching lines @@
   /**
    * @param {HTMLElement} section The section to show or hide.
    * @return {boolean} Whether the section should be shown.
    * @private
    */
   BrowserOptions.shouldShowSection_ = function(section) {
     // If the section is hidden or hiding, it should be shown.
     return section.style.height == '' || section.style.height == '0px';
   };
 
+  BrowserOptions.setMetricsReportingJSCallback = function(success) {

[Alexei Svitkine (slow), 2014/09/05 15:22:48]

Please add a comment explaining this function and what the param means.

[gayane -on leave until 09-2017, 2014/09/05 18:30:20]

Description for the function added, but param removed.

+    // if no success then reverse the checkbox state.
+    if (!success) {

[Alexei Svitkine (slow), 2014/09/05 15:22:48]

If there's nothing to do when !success, how about not calling into JS at all in
that case?

[gayane -on leave until 09-2017, 2014/09/05 18:30:20]

Done.

+      $('metricsReportingEnabled').checked =
+          !$('metricsReportingEnabled').checked;
+    }
+  };
+
   BrowserOptions.prototype = {
     __proto__: Page.prototype,
 
     /**
      * Keeps track of whether the user is signed in or not.
      * @type {boolean}
      * @private
      */
     signedIn_: false,
 
@@ skipping 330 matching lines @@
         // text" where both starting text and ending text may or may not be
         // present, but the split should always be in three pieces.
         var restartElements =
             $('metrics-reporting-reset-restart').querySelectorAll('*');
         for (var i = 0; i < restartTextFragments.length; i++) {
           restartElements[i].textContent = restartTextFragments[i];
         }
         restartElements[1].onclick = function(event) {
           chrome.send('restartBrowser');
         };
+        // Attach the listener for updating the checkbox and restart button.
         var updateMetricsRestartButton = function() {
           $('metrics-reporting-reset-restart').hidden =
               loadTimeData.getBoolean('metricsReportingEnabledAtStart') ==
                   $('metricsReportingEnabled').checked;
         };
-        Preferences.getInstance().addEventListener(
-            $('metricsReportingEnabled').getAttribute('pref'),
-            updateMetricsRestartButton);
+        $('metricsReportingEnabled').onclick = function(event) {
+          chrome.send('coreOptionsMetricsReportingChange',

[Alexei Svitkine (slow), 2014/09/05 15:22:48]

I'd name this something more meaningful than coreOptionsMetricsReportingChange.

[gayane -on leave until 09-2017, 2014/09/05 18:30:20]

changed to metricsReportingCheckboxChanged

+              [Boolean(event.currentTarget.checked)]);
+          updateMetricsRestartButton();
+        };
+        $('metricsReportingEnabled').checked =
+            loadTimeData.getBoolean('metricsReportingEnabledAtStart');
         updateMetricsRestartButton();
       }
       $('networkPredictionOptions').onchange = function(event) {
         var value = (event.target.checked ?
             NetworkPredictionOptions.WIFI_ONLY :
             NetworkPredictionOptions.NEVER);
         var metric = event.target.metric;
         Preferences.setIntegerPref(
             'net.network_prediction_options',
             value,
@@ skipping 1103 matching lines @@
       $('factory-reset-section').hidden = false;
     },
 
     /**
      * Set the checked state of the metrics reporting checkbox.
      * @private
      */
     setMetricsReportingCheckboxState_: function(checked, disabled) {
       $('metricsReportingEnabled').checked = checked;
       $('metricsReportingEnabled').disabled = disabled;
+      if (disabled) {
+        $('metrics-reporting-disabled-icon').setAttribute('controlled-by',
+                                                          'policy');
+      }
     },
 
     /**
      * @private
      */
     setMetricsReportingSettingVisibility_: function(visible) {
       if (visible)
         $('metricsReportingSetting').style.display = 'block';
       else
         $('metricsReportingSetting').style.display = 'none';
@@ skipping 446 matching lines @@
     BrowserOptions.getLoggedInUsername = function() {
       return BrowserOptions.getInstance().username_;
     };
   }
 
   // Export
   return {
     BrowserOptions: BrowserOptions
   };
 });