Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(995)

Side by Side Diff: chrome/browser/metrics/chrome_metrics_service_accessor.h

Issue 506663003: Consolidates accessing and setting the UMA pref to be within metrics code (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: more comments. using accesor class. Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_METRICS_CHROME_METRICS_SERVICE_ACCESSOR_H_ 5 #ifndef CHROME_BROWSER_METRICS_CHROME_METRICS_SERVICE_ACCESSOR_H_
6 #define CHROME_BROWSER_METRICS_CHROME_METRICS_SERVICE_ACCESSOR_H_ 6 #define CHROME_BROWSER_METRICS_CHROME_METRICS_SERVICE_ACCESSOR_H_
7 7
8 #include <stdint.h> 8 #include <stdint.h>
9 #include <string> 9 #include <string>
10 10
11 #include "base/gtest_prod_util.h" 11 #include "base/gtest_prod_util.h"
12 #include "base/macros.h" 12 #include "base/macros.h"
13 #include "chrome/browser/metrics/metrics_service_accessor.h" 13 #include "chrome/browser/metrics/metrics_service_accessor.h"
14 #include "chrome/browser/ui/webui/options/browser_options_handler.h"
14 15
15 class Profile; 16 class Profile;
16 17
17 namespace { 18 namespace {
18 class CrashesDOMHandler; 19 class CrashesDOMHandler;
19 class FlashDOMHandler; 20 class FlashDOMHandler;
20 } 21 }
21 22
22 namespace extensions { 23 namespace extensions {
23 class ExtensionDownloader; 24 class ExtensionDownloader;
(...skipping 17 matching lines...) Expand all
41 friend bool prerender::IsOmniboxEnabled(Profile* profile); 42 friend bool prerender::IsOmniboxEnabled(Profile* profile);
42 friend class ChromeRenderMessageFilter; 43 friend class ChromeRenderMessageFilter;
43 friend class ::CrashesDOMHandler; 44 friend class ::CrashesDOMHandler;
44 friend class DataReductionProxyChromeSettings; 45 friend class DataReductionProxyChromeSettings;
45 friend class extensions::ExtensionDownloader; 46 friend class extensions::ExtensionDownloader;
46 friend class extensions::ManifestFetchData; 47 friend class extensions::ManifestFetchData;
47 friend class extensions::MetricsPrivateGetIsCrashReportingEnabledFunction; 48 friend class extensions::MetricsPrivateGetIsCrashReportingEnabledFunction;
48 friend class ::FlashDOMHandler; 49 friend class ::FlashDOMHandler;
49 friend class system_logs::ChromeInternalLogSource; 50 friend class system_logs::ChromeInternalLogSource;
50 friend class UmaSessionStats; 51 friend class UmaSessionStats;
52 friend class options::BrowserOptionsHandler;
51 53
52 FRIEND_TEST_ALL_PREFIXES(ChromeMetricsServiceAccessorTest, 54 FRIEND_TEST_ALL_PREFIXES(ChromeMetricsServiceAccessorTest,
53 MetricsReportingEnabled); 55 MetricsReportingEnabled);
54 FRIEND_TEST_ALL_PREFIXES(ChromeMetricsServiceAccessorTest, 56 FRIEND_TEST_ALL_PREFIXES(ChromeMetricsServiceAccessorTest,
55 CrashReportingEnabled); 57 CrashReportingEnabled);
56 58
57 // Returns true if prefs::kMetricsReportingEnabled is set. 59 // Returns true if prefs::kMetricsReportingEnabled is set.
58 // TODO(asvitkine): Consolidate the method in MetricsStateManager. 60 // TODO(asvitkine): Consolidate the method in MetricsStateManager.
59 // TODO(asvitkine): This function does not report the correct value on 61 // TODO(asvitkine): This function does not report the correct value on
60 // Android and ChromeOS, see http://crbug.com/362192. 62 // Android and ChromeOS, see http://crbug.com/362192.
(...skipping 17 matching lines...) Expand all
78 // Same as RegisterSyntheticFieldTrial above, but takes a hash for the trial 80 // Same as RegisterSyntheticFieldTrial above, but takes a hash for the trial
79 // name, rather than computing it from the string. 81 // name, rather than computing it from the string.
80 static bool RegisterSyntheticFieldTrialWithNameHash( 82 static bool RegisterSyntheticFieldTrialWithNameHash(
81 uint32_t trial_name_hash, 83 uint32_t trial_name_hash,
82 const std::string& group_name); 84 const std::string& group_name);
83 85
84 DISALLOW_IMPLICIT_CONSTRUCTORS(ChromeMetricsServiceAccessor); 86 DISALLOW_IMPLICIT_CONSTRUCTORS(ChromeMetricsServiceAccessor);
85 }; 87 };
86 88
87 #endif // CHROME_BROWSER_METRICS_CHROME_METRICS_SERVICE_ACCESSOR_H_ 89 #endif // CHROME_BROWSER_METRICS_CHROME_METRICS_SERVICE_ACCESSOR_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698