chrome/browser/resources/options/browser_options.html - Issue 506663003: Consolidates accessing and setting the UMA pref to be within metrics code

Side by Side Diff: chrome/browser/resources/options/browser_options.html

Issue 506663003: Consolidates accessing and setting the UMA pref to be within metrics code (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Minor changes Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/metrics/metrics_reporting_state.cc ('K') | « chrome/browser/policy/configuration_policy_handler_list_factory.cc ('k') | chrome/browser/resources/options/browser_options.js » ('j') | chrome/browser/ui/webui/options/core_options_handler.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <div id="settings" class="page" hidden>	1 <div id="settings" class="page" hidden>

2 <header>	2 <header>

3 <h1 i18n-content="settingsTitle"></h1>	3 <h1 i18n-content="settingsTitle"></h1>

4 </header>	4 </header>

5 <include src="automatic_settings_reset_banner.html">	5 <include src="automatic_settings_reset_banner.html">

6 <if expr="chromeos">	6 <if expr="chromeos">

7 <include src="secondary_user_banner.html">	7 <include src="secondary_user_banner.html">

8 <section>	8 <section>

9 <div id="network-section-header" class="section-header">	9 <div id="network-section-header" class="section-header">

10 <h3 i18n-content="sectionTitleInternet"></h3>	10 <h3 i18n-content="sectionTitleInternet"></h3>

(...skipping 375 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
386 pref="cros.metrics.reportingEnabled" type="checkbox">	386 pref="cros.metrics.reportingEnabled" type="checkbox">

387 <span>	387 <span>

388 <label for="metricsReportingEnabled" i18n-content="enableLogging">	388 <label for="metricsReportingEnabled" i18n-content="enableLogging">

389 </label>	389 </label>

390 <span class="controlled-setting-indicator"	390 <span class="controlled-setting-indicator"

391 pref="cros.metrics.reportingEnabled">	391 pref="cros.metrics.reportingEnabled">

392 </span>	392 </span>

393 </span>	393 </span>

394 </if>	394 </if>

395 <if expr="not chromeos">	395 <if expr="not chromeos">

396 <input id="metricsReportingEnabled"	396 <input id="metricsReportingEnabled" type="checkbox">

397 pref="user_experience_metrics.reporting_enabled" type="checkbox">

398 <span>	397 <span>

399 <label for="metricsReportingEnabled" i18n-content="enableLogging">	398 <label for="metricsReportingEnabled" i18n-content="enableLogging">

400 </label>	399 </label>

401 <span class="controlled-setting-indicator"	400 <span id="metrics-reporting-disabled-icon"

402 pref="user_experience_metrics.reporting_enabled">	401 class="controlled-setting-indicator">

403 </span>	402 </span>

404 <span id="metrics-reporting-reset-restart">	403 <span id="metrics-reporting-reset-restart">

405 <!-- Text filled by JavaScript -->	404 <!-- Text filled by JavaScript -->

406 <span></span><button class=	405 <span></span><button class=

407 "link-button standalone-link-button"></button><span></span>	406 "link-button standalone-link-button"></button><span></span>

408 </span>	407 </span>

409 </span>	408 </span>

410 </if>	409 </if>

411 </span>	410 </span>

412 </div>	411 </div>

(...skipping 563 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
976 <button id="advanced-settings-expander" class="link-button"	975 <button id="advanced-settings-expander" class="link-button"

977 i18n-content="showAdvancedSettings">	976 i18n-content="showAdvancedSettings">

978 </button>	977 </button>

979 <if expr="chromeos">	978 <if expr="chromeos">

980 <button id="version-button" class="link-button" hidden	979 <button id="version-button" class="link-button" hidden

981 i18n-content="browserVersion">	980 i18n-content="browserVersion">

982 </button>	981 </button>

983 </if>	982 </if>

984 </footer>	983 </footer>

985 </div>	984 </div>

OLD	NEW