Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(268)

Side by Side Diff: chrome/browser/resources/options/browser_options.js

Issue 506663003: Consolidates accessing and setting the UMA pref to be within metrics code (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: typedef for callback type Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 cr.define('options', function() { 5 cr.define('options', function() {
6 var OptionsPage = options.OptionsPage; 6 var OptionsPage = options.OptionsPage;
7 var Page = cr.ui.pageManager.Page; 7 var Page = cr.ui.pageManager.Page;
8 var PageManager = cr.ui.pageManager.PageManager; 8 var PageManager = cr.ui.pageManager.PageManager;
9 var ArrayDataModel = cr.ui.ArrayDataModel; 9 var ArrayDataModel = cr.ui.ArrayDataModel;
10 var RepeatingButton = cr.ui.RepeatingButton; 10 var RepeatingButton = cr.ui.RepeatingButton;
(...skipping 365 matching lines...) Expand 10 before | Expand all | Expand 10 after
376 // text" where both starting text and ending text may or may not be 376 // text" where both starting text and ending text may or may not be
377 // present, but the split should always be in three pieces. 377 // present, but the split should always be in three pieces.
378 var restartElements = 378 var restartElements =
379 $('metrics-reporting-reset-restart').querySelectorAll('*'); 379 $('metrics-reporting-reset-restart').querySelectorAll('*');
380 for (var i = 0; i < restartTextFragments.length; i++) { 380 for (var i = 0; i < restartTextFragments.length; i++) {
381 restartElements[i].textContent = restartTextFragments[i]; 381 restartElements[i].textContent = restartTextFragments[i];
382 } 382 }
383 restartElements[1].onclick = function(event) { 383 restartElements[1].onclick = function(event) {
384 chrome.send('restartBrowser'); 384 chrome.send('restartBrowser');
385 }; 385 };
386 // Attach the listener for updating the checkbox and restart button.
386 var updateMetricsRestartButton = function() { 387 var updateMetricsRestartButton = function() {
387 $('metrics-reporting-reset-restart').hidden = 388 $('metrics-reporting-reset-restart').hidden =
388 loadTimeData.getBoolean('metricsReportingEnabledAtStart') == 389 loadTimeData.getBoolean('metricsReportingEnabledAtStart') ==
389 $('metricsReportingEnabled').checked; 390 $('metricsReportingEnabled').checked;
390 }; 391 };
391 Preferences.getInstance().addEventListener( 392 $('metricsReportingEnabled').onclick = function(event) {
392 $('metricsReportingEnabled').getAttribute('pref'), 393 chrome.send('metricsReportingCheckboxChanged',
393 updateMetricsRestartButton); 394 [Boolean(event.currentTarget.checked)]);
395 updateMetricsRestartButton();
396 };
397 $('metricsReportingEnabled').checked =
398 loadTimeData.getBoolean('metricsReportingEnabledAtStart');
394 updateMetricsRestartButton(); 399 updateMetricsRestartButton();
395 } 400 }
396 $('networkPredictionOptions').onchange = function(event) { 401 $('networkPredictionOptions').onchange = function(event) {
397 var value = (event.target.checked ? 402 var value = (event.target.checked ?
398 NetworkPredictionOptions.WIFI_ONLY : 403 NetworkPredictionOptions.WIFI_ONLY :
399 NetworkPredictionOptions.NEVER); 404 NetworkPredictionOptions.NEVER);
400 var metric = event.target.metric; 405 var metric = event.target.metric;
401 Preferences.setIntegerPref( 406 Preferences.setIntegerPref(
402 'net.network_prediction_options', 407 'net.network_prediction_options',
403 value, 408 value,
(...skipping 1104 matching lines...) Expand 10 before | Expand all | Expand 10 after
1508 $('factory-reset-section').hidden = false; 1513 $('factory-reset-section').hidden = false;
1509 }, 1514 },
1510 1515
1511 /** 1516 /**
1512 * Set the checked state of the metrics reporting checkbox. 1517 * Set the checked state of the metrics reporting checkbox.
1513 * @private 1518 * @private
1514 */ 1519 */
1515 setMetricsReportingCheckboxState_: function(checked, disabled) { 1520 setMetricsReportingCheckboxState_: function(checked, disabled) {
1516 $('metricsReportingEnabled').checked = checked; 1521 $('metricsReportingEnabled').checked = checked;
1517 $('metricsReportingEnabled').disabled = disabled; 1522 $('metricsReportingEnabled').disabled = disabled;
1523
1524 // If checkbox gets disabled then add an attribute for displaying the
1525 // special icon. The opposite shouldn't be possible to do.
1526 if (disabled) {
1527 $('metrics-reporting-disabled-icon').setAttribute('controlled-by',
1528 'policy');
1529 }
1518 }, 1530 },
1519 1531
1520 /** 1532 /**
1521 * @private 1533 * @private
1522 */ 1534 */
1523 setMetricsReportingSettingVisibility_: function(visible) { 1535 setMetricsReportingSettingVisibility_: function(visible) {
1524 if (visible) 1536 if (visible)
1525 $('metricsReportingSetting').style.display = 'block'; 1537 $('metricsReportingSetting').style.display = 'block';
1526 else 1538 else
1527 $('metricsReportingSetting').style.display = 'none'; 1539 $('metricsReportingSetting').style.display = 'none';
(...skipping 446 matching lines...) Expand 10 before | Expand all | Expand 10 after
1974 BrowserOptions.getLoggedInUsername = function() { 1986 BrowserOptions.getLoggedInUsername = function() {
1975 return BrowserOptions.getInstance().username_; 1987 return BrowserOptions.getInstance().username_;
1976 }; 1988 };
1977 } 1989 }
1978 1990
1979 // Export 1991 // Export
1980 return { 1992 return {
1981 BrowserOptions: BrowserOptions 1993 BrowserOptions: BrowserOptions
1982 }; 1994 };
1983 }); 1995 });
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698