Consolidates accessing and setting the UMA pref to be within metrics code

chrome/browser/metrics/chrome_metrics_service_accessor.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_METRICS_CHROME_METRICS_SERVICE_ACCESSOR_H_
 #define CHROME_BROWSER_METRICS_CHROME_METRICS_SERVICE_ACCESSOR_H_
 
 #include <stdint.h>
 #include <string>
 
 #include "base/gtest_prod_util.h"
 #include "base/macros.h"
+#include "chrome/browser/metrics/metrics_reporting_state.h"
 #include "chrome/browser/metrics/metrics_service_accessor.h"
 
 class Profile;
 
 namespace {
 class CrashesDOMHandler;
 class FlashDOMHandler;
 }
 
 namespace extensions {
 class ExtensionDownloader;
 class ManifestFetchData;
 class MetricsPrivateGetIsCrashReportingEnabledFunction;
 }
 
 namespace prerender {
 bool IsOmniboxEnabled(Profile* profile);
 }
 
 namespace system_logs {
 class ChromeInternalLogSource;
 }
 
+namespace options {
+class BrowserOptionsHandler;
+}
+
 // This class limits and documents access to metrics service helper methods.
 // Since these methods are private, each user has to be explicitly declared
 // as a 'friend' below.
 class ChromeMetricsServiceAccessor : public MetricsServiceAccessor {
  private:
   friend bool prerender::IsOmniboxEnabled(Profile* profile);
   friend class ChromeRenderMessageFilter;
   friend class ::CrashesDOMHandler;
   friend class DataReductionProxyChromeSettings;
   friend class extensions::ExtensionDownloader;
   friend class extensions::ManifestFetchData;
   friend class extensions::MetricsPrivateGetIsCrashReportingEnabledFunction;
   friend class ::FlashDOMHandler;
   friend class system_logs::ChromeInternalLogSource;
   friend class UmaSessionStats;
+  friend class options::BrowserOptionsHandler;
+  friend void InitiateMetricsReportingChange(
+      bool, const OnMetricsReportingCallbackType);

[stevenjb, 2014/09/12 18:07:41]

nit: const&

[gayane -on leave until 09-2017, 2014/09/12 18:20:11]

Done.

 
   FRIEND_TEST_ALL_PREFIXES(ChromeMetricsServiceAccessorTest,
                            MetricsReportingEnabled);
   FRIEND_TEST_ALL_PREFIXES(ChromeMetricsServiceAccessorTest,
                            CrashReportingEnabled);
 
   // Returns true if prefs::kMetricsReportingEnabled is set.
   // TODO(asvitkine): Consolidate the method in MetricsStateManager.
   // TODO(asvitkine): This function does not report the correct value on
   // Android and ChromeOS, see http://crbug.com/362192.
@@ skipping 17 matching lines @@
   // Same as RegisterSyntheticFieldTrial above, but takes a hash for the trial
   // name, rather than computing it from the string.
   static bool RegisterSyntheticFieldTrialWithNameHash(
       uint32_t trial_name_hash,
       const std::string& group_name);
 
   DISALLOW_IMPLICIT_CONSTRUCTORS(ChromeMetricsServiceAccessor);
 };
 
 #endif  // CHROME_BROWSER_METRICS_CHROME_METRICS_SERVICE_ACCESSOR_H_