chrome/browser/metrics/metrics_reporting_state.h - Issue 506663003: Consolidates accessing and setting the UMA pref to be within metrics code

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/metrics/metrics_reporting_state.h

Issue 506663003: Consolidates accessing and setting the UMA pref to be within metrics code (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: access to prefs moved from browser_options_handle to metrics_reposting_state Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/chromeos/settings/device_settings_provider.cc ('K') | « chrome/browser/metrics/chrome_metrics_service_accessor.h ('k') | chrome/browser/metrics/metrics_reporting_state.cc » ('j') | chrome/browser/metrics/metrics_reporting_state.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef CHROME_BROWSER_METRICS_METRICS_REPORTING_STATE_H_	5 #ifndef CHROME_BROWSER_METRICS_METRICS_REPORTING_STATE_H_

6 #define CHROME_BROWSER_METRICS_METRICS_REPORTING_STATE_H_	6 #define CHROME_BROWSER_METRICS_METRICS_REPORTING_STATE_H_

7	7

8 // Tries to set crash stats upload consent to \|enabled\|. Regardless of success,	8 #include "base/callback.h"

9 // if crash stats uploading is enabled, starts the MetricsService; otherwise	9 #include "components/metrics/metrics_service.h"

10 // stops it.	10

11 // Returns whether crash stats uploading is enabled.	11

12 // TODO(tfarina): This method is pretty confusing. Clean this up and rename it	12 // Calls \|SetGoogleUpdateSettings\| function in FILE thread with a callback
	Alexei Svitkine (slow) 2014/09/04 13:58:03 This is describing an implementation detail. Inste This is describing an implementation detail. Instead, have the comment describe the purpose of this function. gayane -on leave until 09-2017 2014/09/04 18:35:47 Done. Show quoted text On 2014/09/04 13:58:03, Alexei Svitkine wrote: > This is describing an implementation detail. Instead, have the comment describe > the purpose of this function. Done.
13 // to something that makes more sense.	13 // \|SetMetricsReporting\| function which does the remaining necessary changes.

14 bool ResolveMetricsReportingEnabled(bool enabled);	14 void InitiateMetricsReportingChange(

	15 base::Callback<void(bool)> callback_fn, bool enabled);
	Alexei Svitkine (slow) 2014/09/04 13:58:03 Nit: Make the callback the last param. Nit: Make the callback the last param. gayane -on leave until 09-2017 2014/09/04 18:35:47 Done. Show quoted text On 2014/09/04 13:58:03, Alexei Svitkine wrote: > Nit: Make the callback the last param. Done.
	16

	17 // Returns weather MetricsReporting is checked

	18 bool IsMetricsReportingEnabled();

	19

	20 // Returns weather MetricsReporting can be modified by user

	21 bool IsMetricsReportingUserChangable();

15	22

16 #endif // CHROME_BROWSER_METRICS_METRICS_REPORTING_STATE_H_	23 #endif // CHROME_BROWSER_METRICS_METRICS_REPORTING_STATE_H_

OLD	NEW