Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(484)

Side by Side Diff: chrome/browser/resources/options/browser_options.html

Issue 506663003: Consolidates accessing and setting the UMA pref to be within metrics code (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: minor changes and fixes Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 <div id="settings" class="page" hidden> 1 <div id="settings" class="page" hidden>
2 <header> 2 <header>
3 <h1 i18n-content="settingsTitle"></h1> 3 <h1 i18n-content="settingsTitle"></h1>
4 </header> 4 </header>
5 <include src="automatic_settings_reset_banner.html"> 5 <include src="automatic_settings_reset_banner.html">
6 <if expr="chromeos"> 6 <if expr="chromeos">
7 <include src="secondary_user_banner.html"> 7 <include src="secondary_user_banner.html">
8 <section> 8 <section>
9 <div id="network-section-header" class="section-header"> 9 <div id="network-section-header" class="section-header">
10 <h3 i18n-content="sectionTitleInternet"></h3> 10 <h3 i18n-content="sectionTitleInternet"></h3>
(...skipping 352 matching lines...) Expand 10 before | Expand all | Expand 10 after
363 <label> 363 <label>
364 <input id="metricsReportingEnabled" 364 <input id="metricsReportingEnabled"
365 pref="cros.metrics.reportingEnabled" type="checkbox"> 365 pref="cros.metrics.reportingEnabled" type="checkbox">
366 <span i18n-content="enableLogging"></span> 366 <span i18n-content="enableLogging"></span>
367 </label> 367 </label>
368 <span class="controlled-setting-indicator" 368 <span class="controlled-setting-indicator"
369 pref="cros.metrics.reportingEnabled"></span> 369 pref="cros.metrics.reportingEnabled"></span>
370 </if> 370 </if>
371 <if expr="not chromeos"> 371 <if expr="not chromeos">
372 <label> 372 <label>
373 <input id="metricsReportingEnabled" 373 <input id="metricsReportingEnabled" type="checkbox">
374 pref="user_experience_metrics.reporting_enabled" type="checkbox">
375 <span i18n-content="enableLogging"> 374 <span i18n-content="enableLogging">
376 </label> 375 </label>
377 <span class="controlled-setting-indicator" 376 <span id="metrics-reporting-disabled-icon"
378 pref="user_experience_metrics.reporting_enabled"> 377 class="controlled-setting-indicator">
379 </span> 378 </span>
380 <span id="metrics-reporting-reset-restart"> 379 <span id="metrics-reporting-reset-restart">
381 <!-- Text filled by JavaScript --> 380 <!-- Text filled by JavaScript -->
382 <span></span><button class= 381 <span></span><button class=
383 "link-button standalone-link-button"></button><span></span> 382 "link-button standalone-link-button"></button><span></span>
384 </span> 383 </span>
385 </if> 384 </if>
386 </div> 385 </div>
387 </if> <!-- _google_chrome --> 386 </if> <!-- _google_chrome -->
388 <div class="checkbox"> 387 <div class="checkbox">
(...skipping 484 matching lines...) Expand 10 before | Expand all | Expand 10 after
873 <button id="advanced-settings-expander" class="link-button" 872 <button id="advanced-settings-expander" class="link-button"
874 i18n-content="showAdvancedSettings"> 873 i18n-content="showAdvancedSettings">
875 </button> 874 </button>
876 <if expr="chromeos"> 875 <if expr="chromeos">
877 <button id="version-button" class="link-button" hidden 876 <button id="version-button" class="link-button" hidden
878 i18n-content="browserVersion"> 877 i18n-content="browserVersion">
879 </button> 878 </button>
880 </if> 879 </if>
881 </footer> 880 </footer>
882 </div> 881 </div>
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698