Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Side by Side Diff: chrome/browser/metrics/metrics_reporting_state.h

Issue 506663003: Consolidates accessing and setting the UMA pref to be within metrics code (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Return updated state instead of success identifier + minor changes Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_METRICS_METRICS_REPORTING_STATE_H_ 5 #ifndef CHROME_BROWSER_METRICS_METRICS_REPORTING_STATE_H_
6 #define CHROME_BROWSER_METRICS_METRICS_REPORTING_STATE_H_ 6 #define CHROME_BROWSER_METRICS_METRICS_REPORTING_STATE_H_
7 7
8 // Tries to set crash stats upload consent to |enabled|. Regardless of success, 8 #include "base/callback.h"
9 // if crash stats uploading is enabled, starts the MetricsService; otherwise 9 #include "components/metrics/metrics_service.h"
Alexei Svitkine (slow) 2014/09/09 15:27:15 Is this include needed?
gayane -on leave until 09-2017 2014/09/09 19:40:51 Done.
10 // stops it. 10
Alexei Svitkine (slow) 2014/09/09 15:27:15 Nit: Remove extra blank line.
gayane -on leave until 09-2017 2014/09/09 19:40:51 Done.
11 // Returns whether crash stats uploading is enabled. 11
12 // TODO(tfarina): This method is pretty confusing. Clean this up and rename it 12 // Initiates a change to metrics reporting state to the new value of |enabled|.
13 // to something that makes more sense. 13 // Starts or stops the metrics service based on the new state and then runs
14 bool ResolveMetricsReportingEnabled(bool enabled); 14 // |callback_fn| (which can be null) with the updated state (as the operation
15 // may fail). On platforms other than CrOS and Android, also updates the
16 // underlying pref.
17 // TODO(gayane): Support setting the pref on all platforms.
18 void InitiateMetricsReportingChange(bool enabled,
19 base::Callback<void(bool)> callback_fn);
20
21 // Returns whether MetricsReporting can be modified by the user (except CrOS and
22 // Android).
23 bool IsMetricsReportingUserChangable();
15 24
16 #endif // CHROME_BROWSER_METRICS_METRICS_REPORTING_STATE_H_ 25 #endif // CHROME_BROWSER_METRICS_METRICS_REPORTING_STATE_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698