Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Side by Side Diff: chrome/browser/extensions/api/preference/preference_api.cc

Issue 506663003: Consolidates accessing and setting the UMA pref to be within metrics code (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Return updated state instead of success identifier + minor changes Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/extensions/api/preference/preference_api.h" 5 #include "chrome/browser/extensions/api/preference/preference_api.h"
6 6
7 #include <map> 7 #include <map>
8 #include <utility> 8 #include <utility>
9 9
10 #include "base/lazy_instance.h" 10 #include "base/lazy_instance.h"
(...skipping 78 matching lines...) Expand 10 before | Expand all | Expand 10 after
89 {"safeBrowsingEnabled", prefs::kSafeBrowsingEnabled, 89 {"safeBrowsingEnabled", prefs::kSafeBrowsingEnabled,
90 APIPermission::kPrivacy, APIPermission::kPrivacy}, 90 APIPermission::kPrivacy, APIPermission::kPrivacy},
91 {"searchSuggestEnabled", prefs::kSearchSuggestEnabled, 91 {"searchSuggestEnabled", prefs::kSearchSuggestEnabled,
92 APIPermission::kPrivacy, APIPermission::kPrivacy}, 92 APIPermission::kPrivacy, APIPermission::kPrivacy},
93 {"spellingServiceEnabled", prefs::kSpellCheckUseSpellingService, 93 {"spellingServiceEnabled", prefs::kSpellCheckUseSpellingService,
94 APIPermission::kPrivacy, APIPermission::kPrivacy}, 94 APIPermission::kPrivacy, APIPermission::kPrivacy},
95 {"thirdPartyCookiesAllowed", prefs::kBlockThirdPartyCookies, 95 {"thirdPartyCookiesAllowed", prefs::kBlockThirdPartyCookies,
96 APIPermission::kPrivacy, APIPermission::kPrivacy}, 96 APIPermission::kPrivacy, APIPermission::kPrivacy},
97 {"translationServiceEnabled", prefs::kEnableTranslate, 97 {"translationServiceEnabled", prefs::kEnableTranslate,
98 APIPermission::kPrivacy, APIPermission::kPrivacy}, 98 APIPermission::kPrivacy, APIPermission::kPrivacy},
99 {"metricsReportingEnabled", prefs::kMetricsReportingEnabled,
100 APIPermission::kPrivacy, APIPermission::kPrivacy},
99 #if defined(OS_CHROMEOS) 101 #if defined(OS_CHROMEOS)
100 {"autoclick", prefs::kAccessibilityAutoclickEnabled, 102 {"autoclick", prefs::kAccessibilityAutoclickEnabled,
101 APIPermission::kAccessibilityFeaturesRead, 103 APIPermission::kAccessibilityFeaturesRead,
102 APIPermission::kAccessibilityFeaturesModify}, 104 APIPermission::kAccessibilityFeaturesModify},
103 {"highContrast", prefs::kAccessibilityHighContrastEnabled, 105 {"highContrast", prefs::kAccessibilityHighContrastEnabled,
104 APIPermission::kAccessibilityFeaturesRead, 106 APIPermission::kAccessibilityFeaturesRead,
105 APIPermission::kAccessibilityFeaturesModify}, 107 APIPermission::kAccessibilityFeaturesModify},
106 {"largeCursor", prefs::kAccessibilityLargeCursorEnabled, 108 {"largeCursor", prefs::kAccessibilityLargeCursorEnabled,
107 APIPermission::kAccessibilityFeaturesRead, 109 APIPermission::kAccessibilityFeaturesRead,
108 APIPermission::kAccessibilityFeaturesModify}, 110 APIPermission::kAccessibilityFeaturesModify},
(...skipping 603 matching lines...) Expand 10 before | Expand all | Expand 10 after
712 pref_key, PreferenceFunction::PERMISSION_TYPE_WRITE, &browser_pref)) { 714 pref_key, PreferenceFunction::PERMISSION_TYPE_WRITE, &browser_pref)) {
713 return false; 715 return false;
714 } 716 }
715 717
716 PreferenceAPI::Get(GetProfile()) 718 PreferenceAPI::Get(GetProfile())
717 ->RemoveExtensionControlledPref(extension_id(), browser_pref, scope); 719 ->RemoveExtensionControlledPref(extension_id(), browser_pref, scope);
718 return true; 720 return true;
719 } 721 }
720 722
721 } // namespace extensions 723 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698