chrome/browser/resources/options/browser_options.html - Issue 506663003: Consolidates accessing and setting the UMA pref to be within metrics code

Side by Side Diff: chrome/browser/resources/options/browser_options.html

Issue 506663003: Consolidates accessing and setting the UMA pref to be within metrics code (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/metrics/metrics_reporting_state.h ('K') | « chrome/browser/policy/configuration_policy_handler_list_factory.cc ('k') | chrome/browser/resources/options/browser_options.js » ('j') | chrome/browser/resources/options/browser_options.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <div id="settings" class="page" hidden>	1 <div id="settings" class="page" hidden>

2 <header>	2 <header>

3 <h1 i18n-content="settingsTitle"></h1>	3 <h1 i18n-content="settingsTitle"></h1>

4 </header>	4 </header>

5 <include src="automatic_settings_reset_banner.html">	5 <include src="automatic_settings_reset_banner.html">

6 <if expr="chromeos">	6 <if expr="chromeos">

7 <include src="secondary_user_banner.html">	7 <include src="secondary_user_banner.html">

8 <section>	8 <section>

9 <div id="network-section-header" class="section-header">	9 <div id="network-section-header" class="section-header">

10 <h3 i18n-content="sectionTitleInternet"></h3>	10 <h3 i18n-content="sectionTitleInternet"></h3>

(...skipping 391 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
402 pref="cros.metrics.reportingEnabled" type="checkbox">	402 pref="cros.metrics.reportingEnabled" type="checkbox">

403 <span>	403 <span>

404 <label for="metricsReportingEnabled" i18n-content="enableLogging">	404 <label for="metricsReportingEnabled" i18n-content="enableLogging">

405 </label>	405 </label>

406 <span class="controlled-setting-indicator"	406 <span class="controlled-setting-indicator"

407 pref="cros.metrics.reportingEnabled">	407 pref="cros.metrics.reportingEnabled">

408 </span>	408 </span>

409 </span>	409 </span>

410 </if>	410 </if>

411 <if expr="not chromeos">	411 <if expr="not chromeos">

412 <input id="metricsReportingEnabled"	412 <input id="metricsReportingEnabled" type="checkbox">

413 pref="user_experience_metrics.reporting_enabled" type="checkbox">

414 <span>	413 <span>

415 <label for="metricsReportingEnabled" i18n-content="enableLogging">	414 <label for="metricsReportingEnabled" i18n-content="enableLogging">

416 </label>	415 </label>

417 <span class="controlled-setting-indicator"	416 <span id="metrics-reporting-disabled-icon"

418 pref="user_experience_metrics.reporting_enabled">	417 class="controlled-setting-indicator">

419 </span>	418 </span>

420 <span id="metrics-reporting-reset-restart">	419 <span id="metrics-reporting-reset-restart">

421 <!-- Text filled by JavaScript -->	420 <!-- Text filled by JavaScript -->

422 <span></span><button class=	421 <span></span><button class=

423 "link-button standalone-link-button"></button><span></span>	422 "link-button standalone-link-button"></button><span></span>

424 </span>	423 </span>

425 </span>	424 </span>

426 </if>	425 </if>

427 </span>	426 </span>

428 </div>	427 </div>

(...skipping 547 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
976 <button id="advanced-settings-expander" class="link-button"	975 <button id="advanced-settings-expander" class="link-button"

977 i18n-content="showAdvancedSettings">	976 i18n-content="showAdvancedSettings">

978 </button>	977 </button>

979 <if expr="chromeos">	978 <if expr="chromeos">

980 <button id="version-button" class="link-button" hidden	979 <button id="version-button" class="link-button" hidden

981 i18n-content="browserVersion">	980 i18n-content="browserVersion">

982 </button>	981 </button>

983 </if>	982 </if>

984 </footer>	983 </footer>

985 </div>	984 </div>

OLD	NEW