Issue 506603003: Don't hide the scope in chrome://serviceworker-internals/.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 506603003: Don't hide the scope in chrome://serviceworker-internals/. (Closed)

Created:
6 years, 3 months ago by horo

Modified:
6 years, 3 months ago

Reviewers:
nhiroki

CC:
chromium-reviews, darin-cc_chromium.org, jam

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Don't hide the scope in chrome://serviceworker-internals/. Currently max-width is set in .serviceworker-scope. So if the scope is too long, it could be hidden. BUG=N/A Committed: https://crrev.com/4e31fb42eb6c4ee033ff210eef180514edaa9f9d Cr-Commit-Position: refs/heads/master@{#292084}

Patch Set 1 #

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -3 lines)			Patch
	M	content/browser/resources/service_worker/serviceworker_internals.css	View		1 chunk	+0 lines, -3 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

nhiroki

On 2014/08/26 02:21:19, horo wrote: > nhiroki@ > Could you please review? lgtm (rubberstamp)

6 years, 3 months ago (2014-08-27 01:40:39 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/horo@chromium.org/506603003/1

6 years, 3 months ago (2014-08-27 01:42:29 UTC) #5

commit-bot: I haz the power

Committed patchset #1 (1) as 2cea585122cb43009f155a161acab93d5f8d4e64

6 years, 3 months ago (2014-08-27 02:43:36 UTC) #6

commit-bot: I haz the power

6 years, 3 months ago (2014-09-10 02:49:17 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/4e31fb42eb6c4ee033ff210eef180514edaa9f9d
Cr-Commit-Position: refs/heads/master@{#292084}

Expand Messages | Collapse Messages