Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1312)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 506583002: Video Player: Support seek on casting (Closed)

Created:
6 years, 4 months ago by yoshiki
Modified:
6 years, 3 months ago
Reviewers:
fukino
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org, yoshiki+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Video Player: Support seek on casting BUG=397393 TEST=manually tested Committed: https://crrev.com/24501f275c255e303c8ab32b22b63b5611c92ec7 Cr-Commit-Position: refs/heads/master@{#291859}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Addressed the comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -5 lines) Patch
M ui/file_manager/video_player/js/cast/cast_video_element.js View 1 2 chunks +13 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
yoshiki
yoshiki@chromium.org changed reviewers: + fukino@chromium.org
6 years, 4 months ago (2014-08-25 22:49:56 UTC) #1
yoshiki
@fukino-san, PTAL.
6 years, 4 months ago (2014-08-25 22:50:19 UTC) #2
fukino
lgtm with nits: https://codereview.chromium.org/506583002/diff/1/ui/file_manager/video_player/js/cast/cast_video_element.js File ui/file_manager/video_player/js/cast/cast_video_element.js (right): https://codereview.chromium.org/506583002/diff/1/ui/file_manager/video_player/js/cast/cast_video_element.js#newcode93 ui/file_manager/video_player/js/cast/cast_video_element.js:93: set currentTime(currentTime) { nit: Please provide ...
6 years, 4 months ago (2014-08-26 03:45:06 UTC) #3
yoshiki
https://codereview.chromium.org/506583002/diff/1/ui/file_manager/video_player/js/cast/cast_video_element.js File ui/file_manager/video_player/js/cast/cast_video_element.js (right): https://codereview.chromium.org/506583002/diff/1/ui/file_manager/video_player/js/cast/cast_video_element.js#newcode93 ui/file_manager/video_player/js/cast/cast_video_element.js:93: set currentTime(currentTime) { On 2014/08/26 03:45:06, fukino wrote: > ...
6 years, 4 months ago (2014-08-26 04:25:24 UTC) #4
yoshiki
https://codereview.chromium.org/506583002/diff/1/ui/file_manager/video_player/js/cast/cast_video_element.js File ui/file_manager/video_player/js/cast/cast_video_element.js (right): https://codereview.chromium.org/506583002/diff/1/ui/file_manager/video_player/js/cast/cast_video_element.js#newcode126 ui/file_manager/video_player/js/cast/cast_video_element.js:126: * TimeRange objects that represents the seekable ranges of ...
6 years, 4 months ago (2014-08-26 04:25:39 UTC) #5
yoshiki
The CQ bit was checked by yoshiki@chromium.org
6 years, 4 months ago (2014-08-26 04:25:43 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoshiki@chromium.org/506583002/20001
6 years, 4 months ago (2014-08-26 04:27:32 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (20001) as 932532c7a66a4249d513ee3bc6c7bee0657c80c7
6 years, 3 months ago (2014-08-26 07:09:09 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:41:09 UTC) #9
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/24501f275c255e303c8ab32b22b63b5611c92ec7
Cr-Commit-Position: refs/heads/master@{#291859}

Powered by Google App Engine
This is Rietveld 408576698