Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issue 506543002: Move PopupMenu Tests from Source/web/tests to Source/web (Closed)

Created:
6 years, 4 months ago by spartha
Modified:
6 years, 3 months ago
Reviewers:
keishi, tkent
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Move PopupMenu Tests from Source/web/tests to Source/web Move PopupMenuTest and PopupContainerTest to Source/web BUG=353585 R=tkent,keishi Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180891

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -820 lines) Patch
A + Source/web/PopupContainerTest.cpp View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/web/PopupMenuTest.cpp View 7 chunks +8 lines, -8 lines 0 comments Download
D Source/web/tests/PopupContainerTest.cpp View 1 chunk +0 lines, -197 lines 0 comments Download
D Source/web/tests/PopupMenuTest.cpp View 1 chunk +0 lines, -614 lines 0 comments Download
M Source/web/web.gypi View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
spartha
PTAL!
6 years, 4 months ago (2014-08-25 12:42:14 UTC) #1
tkent
> Move PopupMenu Tests from core/web/tests to core/web > > Move the PopupMenuTest, PopupContainerTest to ...
6 years, 4 months ago (2014-08-25 20:17:28 UTC) #2
tkent
lgtm
6 years, 4 months ago (2014-08-25 20:17:42 UTC) #3
spartha
The CQ bit was checked by sudarshan.p@samsung.com
6 years, 3 months ago (2014-08-26 05:47:01 UTC) #4
spartha
The CQ bit was unchecked by sudarshan.p@samsung.com
6 years, 3 months ago (2014-08-26 05:47:21 UTC) #5
spartha
The CQ bit was checked by sudarshan.p@samsung.com
6 years, 3 months ago (2014-08-26 05:49:48 UTC) #6
spartha
The CQ bit was unchecked by sudarshan.p@samsung.com
6 years, 3 months ago (2014-08-26 05:50:04 UTC) #7
spartha
The CQ bit was checked by sudarshan.p@samsung.com
6 years, 3 months ago (2014-08-26 05:50:50 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sudarshan.p@samsung.com/506543002/20001
6 years, 3 months ago (2014-08-26 05:51:07 UTC) #9
commit-bot: I haz the power
6 years, 3 months ago (2014-08-26 08:18:33 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (20001) as 180891

Powered by Google App Engine
This is Rietveld 408576698