net/quic/quic_per_connection_packet_writer.h - Issue 506523002: net : Declaring the weak_ptr_factory in proper order.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: net/quic/quic_per_connection_packet_writer.h

Issue 506523002: net : Declaring the weak_ptr_factory in proper order. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: incorporated the review comments. Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« net/http/http_cache_transaction.cc ('K') | « net/quic/quic_default_packet_writer.cc ('k') | net/quic/quic_server_packet_writer.h » ('j') | no next file with comments »

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef NET_QUIC_QUIC_PER_CONNECTION_PACKET_WRITER_H_	5 #ifndef NET_QUIC_QUIC_PER_CONNECTION_PACKET_WRITER_H_

6 #define NET_QUIC_QUIC_PER_CONNECTION_PACKET_WRITER_H_	6 #define NET_QUIC_QUIC_PER_CONNECTION_PACKET_WRITER_H_

7	7

8 #include "base/memory/weak_ptr.h"	8 #include "base/memory/weak_ptr.h"

9 #include "net/quic/quic_connection.h"	9 #include "net/quic/quic_connection.h"

10 #include "net/quic/quic_packet_writer.h"	10 #include "net/quic/quic_packet_writer.h"

(...skipping 22 matching lines...) Expand all Loading...
33 size_t buf_len,	33 size_t buf_len,

34 const IPAddressNumber& self_address,	34 const IPAddressNumber& self_address,

35 const IPEndPoint& peer_address) OVERRIDE;	35 const IPEndPoint& peer_address) OVERRIDE;

36 virtual bool IsWriteBlockedDataBuffered() const OVERRIDE;	36 virtual bool IsWriteBlockedDataBuffered() const OVERRIDE;

37 virtual bool IsWriteBlocked() const OVERRIDE;	37 virtual bool IsWriteBlocked() const OVERRIDE;

38 virtual void SetWritable() OVERRIDE;	38 virtual void SetWritable() OVERRIDE;

39	39

40 private:	40 private:

41 void OnWriteComplete(WriteResult result);	41 void OnWriteComplete(WriteResult result);

42	42

43 base::WeakPtrFactory<QuicPerConnectionPacketWriter> weak_factory_;

44 QuicServerPacketWriter* shared_writer_; // Not owned.	43 QuicServerPacketWriter* shared_writer_; // Not owned.

45 QuicConnection* connection_; // Not owned.	44 QuicConnection* connection_; // Not owned.

46	45

	46 base::WeakPtrFactory<QuicPerConnectionPacketWriter> weak_factory_;

	47

47 DISALLOW_COPY_AND_ASSIGN(QuicPerConnectionPacketWriter);	48 DISALLOW_COPY_AND_ASSIGN(QuicPerConnectionPacketWriter);

48 };	49 };

49	50

50 } // namespace net	51 } // namespace net

51	52

52 #endif // NET_QUIC_QUIC_PER_CONNECTION_PACKET_WRITER_H_	53 #endif // NET_QUIC_QUIC_PER_CONNECTION_PACKET_WRITER_H_

OLD	NEW