net/http/disk_cache_based_quic_server_info.h - Issue 506523002: net : Declaring the weak_ptr_factory in proper order.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: net/http/disk_cache_based_quic_server_info.h

Issue 506523002: net : Declaring the weak_ptr_factory in proper order. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: incorporated the review comments. Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef NET_HTTP_DISK_CACHE_BASED_QUIC_SERVER_INFO_H_	5 #ifndef NET_HTTP_DISK_CACHE_BASED_QUIC_SERVER_INFO_H_

6 #define NET_HTTP_DISK_CACHE_BASED_QUIC_SERVER_INFO_H_	6 #define NET_HTTP_DISK_CACHE_BASED_QUIC_SERVER_INFO_H_

7	7

8 #include <string>	8 #include <string>

9	9

10 #include "base/memory/ref_counted.h"	10 #include "base/memory/ref_counted.h"

(...skipping 66 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
77 int DoRead();	77 int DoRead();

78 int DoWrite();	78 int DoWrite();

79 int DoCreateOrOpen();	79 int DoCreateOrOpen();

80	80

81 // DoWaitForDataReadyDone is the terminal state of the read operation.	81 // DoWaitForDataReadyDone is the terminal state of the read operation.

82 int DoWaitForDataReadyDone();	82 int DoWaitForDataReadyDone();

83	83

84 // DoSetDone is the terminal state of the write operation.	84 // DoSetDone is the terminal state of the write operation.

85 int DoSetDone();	85 int DoSetDone();

86	86

87 base::WeakPtrFactory<DiskCacheBasedQuicServerInfo> weak_factory_;

88 CacheOperationDataShim* data_shim_; // Owned by \|io_callback_\|.	87 CacheOperationDataShim* data_shim_; // Owned by \|io_callback_\|.

89 CompletionCallback io_callback_;	88 CompletionCallback io_callback_;

90 State state_;	89 State state_;

91 bool ready_;	90 bool ready_;

92 bool found_entry_; // Controls the behavior of DoCreateOrOpen.	91 bool found_entry_; // Controls the behavior of DoCreateOrOpen.

93 std::string new_data_;	92 std::string new_data_;

94 const QuicServerId server_id_;	93 const QuicServerId server_id_;

95 HttpCache* const http_cache_;	94 HttpCache* const http_cache_;

96 disk_cache::Backend* backend_;	95 disk_cache::Backend* backend_;

97 disk_cache::Entry* entry_;	96 disk_cache::Entry* entry_;

98 CompletionCallback user_callback_;	97 CompletionCallback user_callback_;

99 scoped_refptr<IOBuffer> read_buffer_;	98 scoped_refptr<IOBuffer> read_buffer_;

100 scoped_refptr<IOBuffer> write_buffer_;	99 scoped_refptr<IOBuffer> write_buffer_;

101 std::string data_;	100 std::string data_;

	101

	102 base::WeakPtrFactory<DiskCacheBasedQuicServerInfo> weak_factory_;

102 };	103 };

103	104

104 } // namespace net	105 } // namespace net

105	106

106 #endif // NET_HTTP_DISK_CACHE_BASED_QUIC_SERVER_INFO_H_	107 #endif // NET_HTTP_DISK_CACHE_BASED_QUIC_SERVER_INFO_H_

OLD	NEW

« no previous file with comments | « net/base/sdch_dictionary_fetcher.cc ('k') | net/http/disk_cache_based_quic_server_info.cc » ('j') | net/http/http_cache_transaction.cc » ('J')