Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(453)

Issue 506483002: ui: Move ui_unittests.gyp into ui/base. (Closed)

Created:
6 years, 4 months ago by tfarina
Modified:
6 years, 3 months ago
Reviewers:
sky
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, Ben Goodger (Google), danakj
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

ui: Move ui_unittests.gyp into ui/base. ui_unittests.gyp -> ui_base_tests.gyp (follow gfx_tests.gyp pattern). ui_unittests_bundle.gypi -> ui/base/ui_base_tests_bundle.gypi ui_unittests.isolate -> ui_base_tests.isolate Add a TODO assigned to me to rename ui_unittests target to ui_base_unittests when buildbot is updated. BUG=331829, 373148, 299841, 103304 TEST=ui_unittests R=sky@chromium.org Committed: https://crrev.com/63e36e6bdaa65d1152dd62f9831128c752bc0408 Cr-Commit-Position: refs/heads/master@{#292146}

Patch Set 1 #

Patch Set 2 : fix mac? #

Patch Set 3 : missed one cocoa entry #

Patch Set 4 : fix ios? #

Patch Set 5 : fix android #

Unified diffs Side-by-side diffs Delta from patch set Stats (+119 lines, -446 lines) Patch
M build/all.gyp View 11 chunks +10 lines, -10 lines 0 comments Download
M build/android/pylib/gtest/setup.py View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome.gyp View 1 chunk +1 line, -1 line 0 comments Download
A + ui/base/ui_base_tests.gyp View 1 2 3 7 chunks +102 lines, -96 lines 0 comments Download
A + ui/base/ui_base_tests.isolate View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
A + ui/base/ui_base_tests_bundle.gypi View 1 1 chunk +3 lines, -3 lines 0 comments Download
D ui/ui_unittests.gyp View 1 chunk +0 lines, -260 lines 0 comments Download
D ui/ui_unittests.isolate View 1 chunk +0 lines, -18 lines 0 comments Download
D ui/ui_unittests_bundle.gypi View 1 chunk +0 lines, -55 lines 0 comments Download

Messages

Total messages: 16 (0 generated)
tfarina
Hi Scott, could you review this to me? Ben, Dana, fyi! Thanks,
6 years, 4 months ago (2014-08-25 01:49:16 UTC) #1
sky
LGTM
6 years, 4 months ago (2014-08-25 15:31:19 UTC) #2
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 3 months ago (2014-08-26 12:03:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/506483002/40001
6 years, 3 months ago (2014-08-26 12:04:09 UTC) #4
tfarina
The CQ bit was unchecked by tfarina@chromium.org
6 years, 3 months ago (2014-08-26 12:04:11 UTC) #5
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 3 months ago (2014-08-26 12:25:05 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/506483002/60001
6 years, 3 months ago (2014-08-26 12:26:10 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_tests_recipe on tryserver.chromium.linux ...
6 years, 3 months ago (2014-08-26 13:40:01 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 3 months ago (2014-08-26 14:32:36 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_tests_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tests_recipe/builds/2319)
6 years, 3 months ago (2014-08-26 14:32:38 UTC) #10
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 3 months ago (2014-08-27 12:43:59 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/506483002/80001
6 years, 3 months ago (2014-08-27 12:44:29 UTC) #12
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_clang_dbg on tryserver.chromium.linux ...
6 years, 3 months ago (2014-08-27 14:14:02 UTC) #13
commit-bot: I haz the power
Committed patchset #5 (80001) as 60f6892f7223f9d6db92314edb5df9b63d25720f
6 years, 3 months ago (2014-08-27 14:33:15 UTC) #14
tfarina
A revert of this CL (patchset #5 id:80001) has been created in https://codereview.chromium.org/522843002/ by tfarina@chromium.org. ...
6 years, 3 months ago (2014-08-29 17:00:36 UTC) #15
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:51:28 UTC) #16
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/63e36e6bdaa65d1152dd62f9831128c752bc0408
Cr-Commit-Position: refs/heads/master@{#292146}

Powered by Google App Engine
This is Rietveld 408576698