[Enhanced Bookmark] Add GetAllFoldersWithDepth in bookmark bridge

chrome/browser/android/bookmarks/bookmarks_bridge.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/android/bookmarks/bookmarks_bridge.h"
 
 #include "base/android/jni_string.h"
 #include "base/containers/stack_container.h"
 #include "base/prefs/pref_service.h"
 #include "chrome/browser/bookmarks/bookmark_model_factory.h"
@@ skipping 126 matching lines @@
            it = permanent_nodes->begin();
        it != permanent_nodes->end();
        ++it) {
     if (*it != NULL) {
       Java_BookmarksBridge_addToBookmarkIdList(
           env, j_result_obj, (*it)->id(), GetBookmarkType(*it));
     }
   }
 }
 
+void BookmarksBridge::GetEditablePermanentIDs(JNIEnv* env,

[Ted C, 2014/08/28 18:46:21]

Editable is an overloaded term in this file.  We have used it here to specify
whether you can actually edit the node itself (name/title/etc...).  For these,
they aren't really editable, but they are viable parent nodes.

GetPermanentIDsAllowingChildren or something like that is the best that I can
come up with.  I can't say it's a great name, but at least it avoids the
conflict with Editable below.

[Ian Wen, 2014/08/28 21:18:05]

This function is the first step to show folder hierachy in moving bookmark
dialog. It is used to get a list of root folders, i.e. "Desktop", "Other" and
"Mobile". The previous function, GetPermanentNodeIDs, will return folders that
user should not add bookmarks to, such as "Managed folder". What's worse, the
result also contains root node, which is parent of all root folders and their
1st generation children.

After acquiring these "bookmark-addable/movable/allowing" root folders,
getChildIds() is used to traverse the tree.

On 2014/08/28 18:46:21, Ted C wrote:

+                                              jobject obj,
+                                              jobject j_result_obj) {
+  DCHECK(IsLoaded());
+
+  base::StackVector<const BookmarkNode*, 8> permanent_nodes;
+
+  const BookmarkNode* root_node = bookmark_model_->root_node();
+  for (int i = 0; i < root_node->child_count(); ++i) {
+    permanent_nodes->push_back(root_node->GetChild(i));
+  }
+
+  for (base::StackVector<const BookmarkNode*, 8>::ContainerType::const_iterator
+           it = permanent_nodes->begin();
+       it != permanent_nodes->end();
+       ++it) {
+    if (*it != NULL && client_->CanBeEditedByUser((*it))) {

[newt (away), 2014/08/28 18:51:38]

suggestion: check client_->CanBeEditedByUser(*it) on line 156 before calling
permanent_nodes->push_back(). Also, s/((*it))/(*it)

[Ian Wen, 2014/08/28 21:18:05]

Done.

+      Java_BookmarksBridge_addToBookmarkIdList(
+          env, j_result_obj, (*it)->id(), GetBookmarkType(*it));
+    }
+  }
+}
+
 void BookmarksBridge::GetChildIDs(JNIEnv* env,
                                   jobject obj,
                                   jlong id,
                                   jint type,
                                   jboolean get_folders,
                                   jboolean get_bookmarks,
                                   jobject j_result_obj) {
   DCHECK(IsLoaded());
 
   const BookmarkNode* parent = GetNodeByID(id, type);
@@ skipping 495 matching lines @@
   BookmarkModelChanged();
 }
 
 void BookmarksBridge::PartnerShimLoaded(PartnerBookmarksShim* shim) {
   NotifyIfDoneLoading();
 }
 
 void BookmarksBridge::ShimBeingDeleted(PartnerBookmarksShim* shim) {
   partner_bookmarks_shim_ = NULL;
 }