Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(324)

Unified Diff: mojo/public/cpp/application/application_runner_chromium.h

Issue 506353002: Make HandleWatcher watch on the same thread if the thread is running a MessagePumpMojo. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: updated unittests Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/public/cpp/application/application_runner_chromium.h
diff --git a/mojo/public/cpp/application/application_runner_chromium.h b/mojo/public/cpp/application/application_runner_chromium.h
index 6a49b263cf9b4800390931aeee2192da246bcdda..3426c7bac7f23eb6eec7b6ad35554ed263697160 100644
--- a/mojo/public/cpp/application/application_runner_chromium.h
+++ b/mojo/public/cpp/application/application_runner_chromium.h
@@ -22,8 +22,8 @@ class ApplicationDelegate;
// }
//
// ApplicationRunnerChromium takes care of chromium environment initialization
-// and shutdown, and starting a RunLoop from which your application can run and
-// ultimately Quit().
+// and shutdown, and starting a MessageLoop from which your application can run
+// and ultimately Quit().
class ApplicationRunnerChromium {
public:
// Takes ownership of |delegate|.
@@ -33,15 +33,18 @@ class ApplicationRunnerChromium {
void set_message_loop_type(base::MessageLoop::Type type);
// Once the various parameters have been set above, use Run to initialize an
- // ApplicationImpl wired to the provided delegate, and run a RunLoop until
+ // ApplicationImpl wired to the provided delegate, and run a MessageLoop until
// the application exits.
MojoResult Run(MojoHandle shell_handle);
private:
scoped_ptr<ApplicationDelegate> delegate_;
- // MessageLoop type. TYPE_DEFAULT is default.
+ // MessageLoop type. TYPE_CUSTOM is default (MessagePumpMojo will be used as
+ // the underlying message pump).
base::MessageLoop::Type message_loop_type_;
+ // Whether Run() has been called.
+ bool has_run_;
MOJO_DISALLOW_COPY_AND_ASSIGN(ApplicationRunnerChromium);
};

Powered by Google App Engine
This is Rietveld 408576698