Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issue 506303002: ozone: evdev: Fix ghost touches aligned with first touch (Closed)

Created:
6 years, 3 months ago by spang
Modified:
6 years, 3 months ago
CC:
chromium-reviews, rjkroege, kalyank, tdresser+watch_chromium.org, ozone-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

ozone: evdev: Fix ghost touches aligned with first touch The ABS_X and ABS_Y axes are not part of the MT protocol and should therefore not be used to update MT slot positions. The symptom of this was secondary touches warping to the position of the first touch in the X and/or Y axis, since ABS_X/Y always corresponds to the first touch. BUG=407386 TEST=chrome on pixel with --ash-touch-hud NOTRY=true Committed: https://crrev.com/86c315c379bfeefe3dd833cee678a41ac6884a74 Cr-Commit-Position: refs/heads/master@{#292263}

Patch Set 1 #

Patch Set 2 : add unit test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -4 lines) Patch
M ui/events/ozone/evdev/touch_event_converter_evdev.cc View 1 4 chunks +1 line, -4 lines 0 comments Download
M ui/events/ozone/evdev/touch_event_converter_evdev_unittest.cc View 1 1 chunk +45 lines, -0 lines 0 comments Download

Messages

Total messages: 31 (0 generated)
spang
spang@chromium.org changed reviewers: + alexst@chromium.org, miletus@chromium.org
6 years, 3 months ago (2014-08-26 22:21:11 UTC) #1
spang
6 years, 3 months ago (2014-08-26 22:21:11 UTC) #2
Yufeng Shen (Slow to review)
miletus@chromium.org changed reviewers: + sadrul@chromium.org
6 years, 3 months ago (2014-08-26 23:32:15 UTC) #3
alexst (slow to review)
Does anyone care about ABS_X/Y? explicitly? If not, lgtm.
6 years, 3 months ago (2014-08-27 00:13:04 UTC) #4
sadrul
LGTM A test in touch_event_converter_evdev_unittest.cc?
6 years, 3 months ago (2014-08-27 01:37:22 UTC) #5
spang
The CQ bit was checked by spang@chromium.org
6 years, 3 months ago (2014-08-27 05:29:30 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/spang@chromium.org/506303002/1
6 years, 3 months ago (2014-08-27 05:30:23 UTC) #7
spang
The CQ bit was unchecked by spang@chromium.org
6 years, 3 months ago (2014-08-27 05:33:18 UTC) #8
spang
The CQ bit was checked by spang@chromium.org
6 years, 3 months ago (2014-08-27 23:05:23 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/spang@chromium.org/506303002/20001
6 years, 3 months ago (2014-08-27 23:07:11 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 3 months ago (2014-08-27 23:11:44 UTC) #11
commit-bot: I haz the power
Failed to commit the patch.
6 years, 3 months ago (2014-08-27 23:11:45 UTC) #12
spang
The CQ bit was checked by spang@chromium.org
6 years, 3 months ago (2014-08-27 23:15:21 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/spang@chromium.org/506303002/20001
6 years, 3 months ago (2014-08-27 23:16:37 UTC) #14
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 3 months ago (2014-08-27 23:18:14 UTC) #15
commit-bot: I haz the power
Failed to commit the patch.
6 years, 3 months ago (2014-08-27 23:18:15 UTC) #16
alexst (slow to review)
The CQ bit was checked by alexst@chromium.org
6 years, 3 months ago (2014-08-27 23:20:26 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/spang@chromium.org/506303002/20001
6 years, 3 months ago (2014-08-27 23:21:53 UTC) #18
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 3 months ago (2014-08-27 23:23:09 UTC) #19
commit-bot: I haz the power
Failed to commit the patch.
6 years, 3 months ago (2014-08-27 23:23:10 UTC) #20
spang
The CQ bit was checked by spang@chromium.org
6 years, 3 months ago (2014-08-27 23:23:42 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/spang@chromium.org/506303002/20001
6 years, 3 months ago (2014-08-27 23:24:45 UTC) #22
spang
The CQ bit was unchecked by spang@chromium.org
6 years, 3 months ago (2014-08-27 23:24:49 UTC) #23
spang
The CQ bit was checked by spang@chromium.org
6 years, 3 months ago (2014-08-27 23:24:49 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/spang@chromium.org/506303002/20001
6 years, 3 months ago (2014-08-27 23:26:07 UTC) #25
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 3 months ago (2014-08-27 23:27:36 UTC) #26
commit-bot: I haz the power
Failed to commit the patch.
6 years, 3 months ago (2014-08-27 23:27:37 UTC) #27
spang
The CQ bit was checked by spang@chromium.org
6 years, 3 months ago (2014-08-27 23:30:37 UTC) #28
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/spang@chromium.org/506303002/20001
6 years, 3 months ago (2014-08-27 23:32:22 UTC) #29
commit-bot: I haz the power
Committed patchset #2 (id:20001) as f59f314d1929edc62c5873858fa96308f75738d5
6 years, 3 months ago (2014-08-27 23:34:23 UTC) #30
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:55:28 UTC) #31
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/86c315c379bfeefe3dd833cee678a41ac6884a74
Cr-Commit-Position: refs/heads/master@{#292263}

Powered by Google App Engine
This is Rietveld 408576698