Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 506283002: Mark android supports H264 main/high profile (Closed)

Created:
6 years, 3 months ago by qinmin
Modified:
6 years, 3 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Mark android supports H264 main/high profile Most hardware OEMs provides codecs to support H264 main/high profile. The current way of declaring them as unsupported is too restrictive. BUG=407741 Committed: https://crrev.com/d9b32ee803870c87f65351766e5a731f41172299 Cr-Commit-Position: refs/heads/master@{#292395}

Patch Set 1 #

Total comments: 2

Patch Set 2 : remove comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -5 lines) Patch
M net/base/mime_util.cc View 1 2 chunks +2 lines, -5 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
qinmin
qinmin@chromium.org changed reviewers: + acolwell@chromium.org, mmenke@chromium.org
6 years, 3 months ago (2014-08-26 21:20:31 UTC) #1
qinmin
PTAL
6 years, 3 months ago (2014-08-26 21:20:31 UTC) #2
acolwell GONE FROM CHROMIUM
lgtm. You might want to double check to make sure that this doesn't end up ...
6 years, 3 months ago (2014-08-26 22:38:50 UTC) #3
qinmin
run the content_browsertests on android, and seems it works fine. https://codereview.chromium.org/506283002/diff/1/net/base/mime_util.cc File net/base/mime_util.cc (right): https://codereview.chromium.org/506283002/diff/1/net/base/mime_util.cc#newcode475 ...
6 years, 3 months ago (2014-08-27 00:26:41 UTC) #4
mmenke
On 2014/08/27 00:26:41, qinmin wrote: > run the content_browsertests on android, and seems it works ...
6 years, 3 months ago (2014-08-27 14:30:19 UTC) #5
qinmin
The CQ bit was checked by qinmin@chromium.org
6 years, 3 months ago (2014-08-27 15:58:07 UTC) #6
qinmin
The CQ bit was unchecked by qinmin@chromium.org
6 years, 3 months ago (2014-08-27 15:58:46 UTC) #7
xhwang
On 2014/08/27 15:58:46, qinmin wrote: > The CQ bit was unchecked by mailto:qinmin@chromium.org Can we ...
6 years, 3 months ago (2014-08-28 04:06:23 UTC) #8
qinmin
The CQ bit was checked by qinmin@chromium.org
6 years, 3 months ago (2014-08-28 14:19:35 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/qinmin@chromium.org/506283002/20001
6 years, 3 months ago (2014-08-28 14:20:55 UTC) #10
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_chromium_rel_swarming on tryserver.chromium.mac ...
6 years, 3 months ago (2014-08-28 15:44:16 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001) as ced009f2a773ceec4f3305a97e22733dbfb685f1
6 years, 3 months ago (2014-08-28 16:17:45 UTC) #12
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:00:00 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d9b32ee803870c87f65351766e5a731f41172299
Cr-Commit-Position: refs/heads/master@{#292395}

Powered by Google App Engine
This is Rietveld 408576698