Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(324)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 506273004: Removed redundant PrintingUIWebContentsObserver. (Closed)

Created:
6 years, 3 months ago by Vitaly Buka (NO REVIEWS)
Modified:
6 years, 3 months ago
Reviewers:
Lei Zhang, Noam Samuel
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Removed redundant PrintingUIWebContentsObserver. BUG=374321 Committed: https://crrev.com/d4cb64a052766516bc651d95fbdce06a015aac8a Cr-Commit-Position: refs/heads/master@{#292022}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Tue Aug 26 14:12:01 PDT 2014 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -99 lines) Patch
M chrome/browser/printing/print_job_worker.h View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/printing/print_job_worker.cc View 1 2 chunks +9 lines, -35 lines 0 comments Download
M chrome/browser/printing/printer_query.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/printing/printing_message_filter.cc View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/browser/printing/printing_ui_web_contents_observer.h View 1 chunk +0 lines, -30 lines 0 comments Download
D chrome/browser/printing/printing_ui_web_contents_observer.cc View 1 chunk +0 lines, -27 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
Vitaly Buka (NO REVIEWS)
vitalybuka@chromium.org changed reviewers: + noamsml@chromium.org
6 years, 3 months ago (2014-08-26 21:05:39 UTC) #1
Vitaly Buka (NO REVIEWS)
6 years, 3 months ago (2014-08-26 21:05:39 UTC) #2
Noam Samuel
lgtm https://codereview.chromium.org/506273004/diff/1/chrome/browser/printing/print_job_worker.cc File chrome/browser/printing/print_job_worker.cc (left): https://codereview.chromium.org/506273004/diff/1/chrome/browser/printing/print_job_worker.cc#oldcode62 chrome/browser/printing/print_job_worker.cc:62: DCHECK_CURRENTLY_ON(BrowserThread::UI); Have DCHECK for new thread if it ...
6 years, 3 months ago (2014-08-26 21:09:30 UTC) #3
Vitaly Buka (NO REVIEWS)
vitalybuka@chromium.org changed reviewers: + thestig@chromium.org
6 years, 3 months ago (2014-08-26 21:09:53 UTC) #4
Vitaly Buka (NO REVIEWS)
Lei, observer was introduced by https://codereview.chromium.org/27451002/ Could we just keep IDs?
6 years, 3 months ago (2014-08-26 21:09:54 UTC) #5
Vitaly Buka (NO REVIEWS)
https://codereview.chromium.org/506273004/diff/1/chrome/browser/printing/print_job_worker.cc File chrome/browser/printing/print_job_worker.cc (left): https://codereview.chromium.org/506273004/diff/1/chrome/browser/printing/print_job_worker.cc#oldcode62 chrome/browser/printing/print_job_worker.cc:62: DCHECK_CURRENTLY_ON(BrowserThread::UI); On 2014/08/26 21:09:30, Noam Samuel wrote: > Have ...
6 years, 3 months ago (2014-08-26 21:12:24 UTC) #6
Vitaly Buka (NO REVIEWS)
The CQ bit was checked by vitalybuka@chromium.org
6 years, 3 months ago (2014-08-26 21:13:24 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/506273004/20001
6 years, 3 months ago (2014-08-26 21:16:13 UTC) #8
Lei Zhang
lgtm
6 years, 3 months ago (2014-08-26 21:28:54 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (20001) as 792dae3aec01e52821ff3717f9506f70daefef27
6 years, 3 months ago (2014-08-26 23:10:51 UTC) #10
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:47:04 UTC) #11
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/d4cb64a052766516bc651d95fbdce06a015aac8a
Cr-Commit-Position: refs/heads/master@{#292022}

Powered by Google App Engine
This is Rietveld 408576698