Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6950)

Unified Diff: chrome/browser/printing/print_job_worker.cc

Issue 506163002: Remove implicit conversions from scoped_refptr to T* in chrome/browser/printing/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/printing/print_job_worker.cc
diff --git a/chrome/browser/printing/print_job_worker.cc b/chrome/browser/printing/print_job_worker.cc
index 2dcd7887343b3bfdc100bbde7300ca41d314b7ae..4e79203acfda28a8c8685eb0e5490549dae7a8ae 100644
--- a/chrome/browser/printing/print_job_worker.cc
+++ b/chrome/browser/printing/print_job_worker.cc
@@ -245,7 +245,7 @@ void PrintJobWorker::UseDefaultSettings() {
void PrintJobWorker::StartPrinting(PrintedDocument* new_document) {
DCHECK(task_runner_->RunsTasksOnCurrentThread());
DCHECK_EQ(page_number_, PageNumber::npos());
- DCHECK_EQ(document_, new_document);
+ DCHECK_EQ(document_.get(), new_document);
DCHECK(document_.get());
if (!document_.get() || page_number_ != PageNumber::npos() ||
@@ -311,7 +311,7 @@ void PrintJobWorker::OnNewPage() {
while (true) {
// Is the page available?
scoped_refptr<PrintedPage> page = document_->GetPage(page_number_.ToInt());
- if (!page) {
+ if (!page.get()) {
// We need to wait for the page to be available.
base::MessageLoop::current()->PostDelayedTask(
FROM_HERE,
@@ -343,7 +343,7 @@ bool PrintJobWorker::IsRunning() const {
bool PrintJobWorker::PostTask(const tracked_objects::Location& from_here,
const base::Closure& task) {
- if (task_runner_)
+ if (task_runner_.get())
return task_runner_->PostTask(from_here, task);
return false;
}
« no previous file with comments | « chrome/browser/printing/print_job_manager.cc ('k') | chrome/browser/printing/print_preview_message_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698