Remove implicit conversions from scoped_refptr to T* in chrome/browser/prefs/

chrome/browser/prefs/profile_pref_store_manager.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/prefs/profile_pref_store_manager.h"
 
 #include "base/bind.h"
 #include "base/callback.h"
 #include "base/files/file_util.h"
 #include "base/json/json_file_value_serializer.h"
@@ skipping 69 matching lines @@
   PrefHashFilter::ClearResetTime(pref_service);
 }
 
 PersistentPrefStore* ProfilePrefStoreManager::CreateProfilePrefStore(
     const scoped_refptr<base::SequencedTaskRunner>& io_task_runner,
     const base::Closure& on_reset_on_load,
     TrackedPreferenceValidationDelegate* validation_delegate) {
   scoped_ptr<PrefFilter> pref_filter;
   if (!kPlatformSupportsPreferenceTracking) {
     return new JsonPrefStore(GetPrefFilePathFromProfilePath(profile_path_),
-                             io_task_runner,
+                             io_task_runner.get(),

[gab, 2014/08/26 19:29:56]

JsonPrefStore's constructor should take a scoped_refptr instead as that's what
this pointer then gets stored into.

                              scoped_ptr<PrefFilter>());
   }
 
   std::vector<PrefHashFilter::TrackedPreferenceMetadata>
       unprotected_configuration;
   std::vector<PrefHashFilter::TrackedPreferenceMetadata>
       protected_configuration;
   std::set<std::string> protected_pref_names;
   std::set<std::string> unprotected_pref_names;
   for (std::vector<PrefHashFilter::TrackedPreferenceMetadata>::const_iterator
@@ skipping 24 matching lines @@
                          reporting_ids_count_,
                          true));
 
   PrefHashFilter* raw_unprotected_pref_hash_filter =
       unprotected_pref_hash_filter.get();
   PrefHashFilter* raw_protected_pref_hash_filter =
       protected_pref_hash_filter.get();
 
   scoped_refptr<JsonPrefStore> unprotected_pref_store(
       new JsonPrefStore(GetPrefFilePathFromProfilePath(profile_path_),
-                        io_task_runner,
+                        io_task_runner.get(),

[gab, 2014/08/26 19:29:56]

Same as above.

                         unprotected_pref_hash_filter.PassAs<PrefFilter>()));
   // TODO(gab): Remove kDeprecatedProtectedPreferencesFilename as an alternate
   // file in M40+.
   scoped_refptr<JsonPrefStore> protected_pref_store(new JsonPrefStore(
       profile_path_.Append(chrome::kSecurePreferencesFilename),
       profile_path_.Append(chrome::kProtectedPreferencesFilenameDeprecated),
-      io_task_runner,
+      io_task_runner.get(),

[gab, 2014/08/26 19:29:56]

Same as above.

       protected_pref_hash_filter.PassAs<PrefFilter>()));
 
   SetupTrackedPreferencesMigration(
       unprotected_pref_names,
       protected_pref_names,
       base::Bind(&JsonPrefStore::RemoveValueSilently,
                  unprotected_pref_store->AsWeakPtr()),
       base::Bind(&JsonPrefStore::RemoveValueSilently,
                  protected_pref_store->AsWeakPtr()),
       base::Bind(&JsonPrefStore::RegisterOnNextSuccessfulWriteCallback,
@@ skipping 60 matching lines @@
             profile_path_.AsUTF8Unsafe(), local_state_)));
     pref_filter.reset(
         new PrefHashFilter(pref_hash_store_impl.PassAs<PrefHashStore>(),
                            tracking_configuration_,
                            base::Closure(),
                            NULL,
                            reporting_ids_count_,
                            false));
   }
   return new JsonPrefStore(GetPrefFilePathFromProfilePath(profile_path_),
-                           io_task_runner,
+                           io_task_runner.get(),

[gab, 2014/08/26 19:29:55]

Same as above.

                            pref_filter.Pass());
 }
 
 scoped_ptr<PrefHashStore> ProfilePrefStoreManager::GetPrefHashStore(
     bool use_super_mac) {
   DCHECK(kPlatformSupportsPreferenceTracking);
 
   return scoped_ptr<PrefHashStore>(new PrefHashStoreImpl(
       seed_,
       device_id_,
       use_super_mac));
 }